From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: netdev@vger.kernel.org, sriharsha.basavapatna@broadcom.com,
ajit.khaparde@broadcom.com, sathya.perla@broadcom.com,
sd@queasysnail.net
Subject: Re: [PATCH net] be2net: don't flip hw_features when VXLANs are added/deleted
Date: Fri, 05 Oct 2018 00:59:44 -0700 (PDT) [thread overview]
Message-ID: <20181005.005944.676060322932993396.davem@davemloft.net> (raw)
In-Reply-To: <e296246a78d757683297fd6dbe073dcaa47e467d.1538572109.git.dcaratti@redhat.com>
From: Davide Caratti <dcaratti@redhat.com>
Date: Wed, 3 Oct 2018 15:20:58 +0200
> the be2net implementation of .ndo_tunnel_{add,del}() changes the value of
> NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets
> to call netdev_features_change(). Moreover, ethtool setting for that bit
> can potentially be reverted after a tunnel is added or removed.
>
> GSO already does software segmentation when 'hw_enc_features' is 0, even
> if VXLAN offload is turned on. In addition, commit 096de2f83ebc ("benet:
> stricter vxlan offloading check in be_features_check") avoids hardware
> segmentation of non-VXLAN tunneled packets, or VXLAN packets having wrong
> destination port. So, it's safe to avoid flipping the above feature on
> addition/deletion of VXLAN tunnels.
>
> Fixes: 630f4b70567f ("be2net: Export tunnel offloads only when a VxLAN tunnel is created")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Applied, thank you.
prev parent reply other threads:[~2018-10-05 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 13:20 [PATCH net] be2net: don't flip hw_features when VXLANs are added/deleted Davide Caratti
2018-10-05 7:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005.005944.676060322932993396.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=dcaratti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=sd@queasysnail.net \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox