From: David Miller <davem@davemloft.net>
To: baruch@tkos.co.il
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
linux@armlinux.org.uk, antoine.tenart@bootlin.com,
gregory.clement@bootlin.com, ori.shemtov@solid-run.com
Subject: Re: [PATCH v2] net: phy: phylink: fix SFP interface autodetection
Date: Fri, 05 Oct 2018 01:05:09 -0700 (PDT) [thread overview]
Message-ID: <20181005.010509.468706187273505393.davem@davemloft.net> (raw)
In-Reply-To: <8b8a01c07bf9b85c09de2d6d6b08068d384e37b8.1538582689.git.baruch@tkos.co.il>
From: Baruch Siach <baruch@tkos.co.il>
Date: Wed, 3 Oct 2018 19:04:49 +0300
> When connecting SFP PHY to phylink use the detected interface.
> Otherwise, the link fails to come up when the configured 'phy-mode'
> differs from the SFP detected mode.
>
> Move most of phylink_connect_phy() into __phylink_connect_phy(), and
> leave phylink_connect_phy() as a wrapper. phylink_sfp_connect_phy() can
> now pass the SFP detected PHY interface to __phylink_connect_phy().
>
> This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that
> is configured in the DT to "2500base-x" phy-mode.
>
> Fixes: 9525ae83959b6 ("phylink: add phylink infrastructure")
> Suggested-by: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v2: Leave the phylink_connect_phy() functionality unchanged. Only
> phylink_sfp_connect_phy() calls __phylink_connect_phy() with the
> detected interface (Russell King)
Applied and queued up for -stable.
prev parent reply other threads:[~2018-10-05 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 16:04 [PATCH v2] net: phy: phylink: fix SFP interface autodetection Baruch Siach
2018-10-05 8:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005.010509.468706187273505393.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ori.shemtov@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox