From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dhowells@redhat.com, arnd@arndb.de, netdev@vger.kernel.org,
linux-afs@lists.infradead.org
Subject: Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6
Date: Fri, 12 Oct 2018 11:11:30 -0700 (PDT) [thread overview]
Message-ID: <20181012.111130.2147603962642962519.davem@davemloft.net> (raw)
In-Reply-To: <9ee1a767-b865-6afa-91a2-311422b8338d@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 12 Oct 2018 08:19:20 -0700
>
>
> On 10/12/2018 07:52 AM, David Howells wrote:
>> The udpv6_encap_enable() function is part of the ipv6 code, and if that is
>> configured as a loadable module and rxrpc is built in then a build failure
>> will occur because the conditional check is wrong:
>>
>> net/rxrpc/local_object.o: In function `rxrpc_lookup_local':
>> local_object.c:(.text+0x2688): undefined reference to `udpv6_encap_enable'
>>
>> Use the correct config symbol (CONFIG_AF_RXRPC_IPV6) in the conditional
>> check rather than CONFIG_IPV6 as that will do the right thing.
>>
>> Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
>> Signed-off-by: David Howells <dhowells@redhat.com>
>> cc: Arnd Bergmann <arnd@arndb.de>
>
> Nit : Correct attribution would require a Reported-by: tag
Right.
next prev parent reply other threads:[~2018-10-13 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 14:52 [PATCH net] rxrpc: Fix incorrect conditional on IPV6 David Howells
2018-10-12 15:19 ` Eric Dumazet
2018-10-12 15:37 ` David Howells
2018-10-12 18:11 ` David Miller [this message]
2018-10-12 20:15 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2018-10-12 15:38 David Howells
2018-10-16 5:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012.111130.2147603962642962519.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox