* [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi
@ 2018-10-17 14:24 Nicolas Dichtel
2018-10-17 15:40 ` Quentin Monnet
2018-10-18 4:49 ` Alexei Starovoitov
0 siblings, 2 replies; 4+ messages in thread
From: Nicolas Dichtel @ 2018-10-17 14:24 UTC (permalink / raw)
To: ast, daniel, davem; +Cc: netdev, Nicolas Dichtel, Quentin Monnet
len_diff is signed.
Fixes: fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")
CC: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
include/uapi/linux/bpf.h | 2 +-
tools/include/uapi/linux/bpf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 66917a4eba27..c4ffe91d5598 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -1430,7 +1430,7 @@ union bpf_attr {
* Return
* 0 on success, or a negative error in case of failure.
*
- * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
+ * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
* Description
* Grow or shrink the room for data in the packet associated to
* *skb* by *len_diff*, and according to the selected *mode*.
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 66917a4eba27..c4ffe91d5598 100644
--- a/tools/include/uapi/linux/bpf.h
+++ b/tools/include/uapi/linux/bpf.h
@@ -1430,7 +1430,7 @@ union bpf_attr {
* Return
* 0 on success, or a negative error in case of failure.
*
- * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
+ * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
* Description
* Grow or shrink the room for data in the packet associated to
* *skb* by *len_diff*, and according to the selected *mode*.
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi
2018-10-17 14:24 [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi Nicolas Dichtel
@ 2018-10-17 15:40 ` Quentin Monnet
2018-10-18 4:49 ` Alexei Starovoitov
1 sibling, 0 replies; 4+ messages in thread
From: Quentin Monnet @ 2018-10-17 15:40 UTC (permalink / raw)
To: Nicolas Dichtel, ast, daniel, davem; +Cc: netdev
2018-10-17 16:24 UTC+0200 ~ Nicolas Dichtel <nicolas.dichtel@6wind.com>
> len_diff is signed.
>
> Fixes: fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")
> CC: Quentin Monnet <quentin.monnet@netronome.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> include/uapi/linux/bpf.h | 2 +-
> tools/include/uapi/linux/bpf.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 66917a4eba27..c4ffe91d5598 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1430,7 +1430,7 @@ union bpf_attr {
> * Return
> * 0 on success, or a negative error in case of failure.
> *
> - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
> + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
> * Description
> * Grow or shrink the room for data in the packet associated to
> * *skb* by *len_diff*, and according to the selected *mode*.
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 66917a4eba27..c4ffe91d5598 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -1430,7 +1430,7 @@ union bpf_attr {
> * Return
> * 0 on success, or a negative error in case of failure.
> *
> - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
> + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
> * Description
> * Grow or shrink the room for data in the packet associated to
> * *skb* by *len_diff*, and according to the selected *mode*.
>
Correct, thank you Nicolas! :)
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi
2018-10-17 14:24 [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi Nicolas Dichtel
2018-10-17 15:40 ` Quentin Monnet
@ 2018-10-18 4:49 ` Alexei Starovoitov
2018-10-18 6:21 ` Nicolas Dichtel
1 sibling, 1 reply; 4+ messages in thread
From: Alexei Starovoitov @ 2018-10-18 4:49 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: ast, daniel, davem, netdev, Quentin Monnet
On Wed, Oct 17, 2018 at 04:24:48PM +0200, Nicolas Dichtel wrote:
> len_diff is signed.
>
> Fixes: fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")
> CC: Quentin Monnet <quentin.monnet@netronome.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> include/uapi/linux/bpf.h | 2 +-
> tools/include/uapi/linux/bpf.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 66917a4eba27..c4ffe91d5598 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1430,7 +1430,7 @@ union bpf_attr {
> * Return
> * 0 on success, or a negative error in case of failure.
> *
> - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
> + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
Thanks. Applied to bpf-next, since we're very late into release cycle.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi
2018-10-18 4:49 ` Alexei Starovoitov
@ 2018-10-18 6:21 ` Nicolas Dichtel
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Dichtel @ 2018-10-18 6:21 UTC (permalink / raw)
To: Alexei Starovoitov; +Cc: ast, daniel, davem, netdev, Quentin Monnet
Le 18/10/2018 à 06:49, Alexei Starovoitov a écrit :
> On Wed, Oct 17, 2018 at 04:24:48PM +0200, Nicolas Dichtel wrote:
>> len_diff is signed.
>>
>> Fixes: fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")
>> CC: Quentin Monnet <quentin.monnet@netronome.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>> ---
>> include/uapi/linux/bpf.h | 2 +-
>> tools/include/uapi/linux/bpf.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 66917a4eba27..c4ffe91d5598 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -1430,7 +1430,7 @@ union bpf_attr {
>> * Return
>> * 0 on success, or a negative error in case of failure.
>> *
>> - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
>> + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
>
> Thanks. Applied to bpf-next, since we're very late into release cycle.
>
Yep, I was also wondering if it was not too late for the bpf tree ;-)
Thank you,
Nicolas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-18 14:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-17 14:24 [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi Nicolas Dichtel
2018-10-17 15:40 ` Quentin Monnet
2018-10-18 4:49 ` Alexei Starovoitov
2018-10-18 6:21 ` Nicolas Dichtel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox