Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Amritha Nambiar <amritha.nambiar@intel.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
	jakub.kicinski@netronome.com, sridhar.samudrala@intel.com,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com
Subject: Re: [iproute2 PATCH] tc: flower: Classify packets based port ranges
Date: Thu, 18 Oct 2018 14:21:36 +0200	[thread overview]
Message-ID: <20181018122136.GB4558@nanopsycho.orion> (raw)
In-Reply-To: <153935248286.11074.7540456677759477097.stgit@anamhost.jf.intel.com>

Fri, Oct 12, 2018 at 03:54:42PM CEST, amritha.nambiar@intel.com wrote:

[...]

>@@ -1516,6 +1625,22 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
> 	if (nl_type >= 0)
> 		flower_print_port("src_port", tb[nl_type]);
> 
>+	if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_DST, &range)
>+	    == 0) {
>+		flower_print_port_range("dst_port_min",
>+					tb[range.min_port_type]);
>+		flower_print_port_range("dst_port_max",
>+					tb[range.max_port_type]);

The input and output of iproute2 utils, tc included should be in sync.
So you need to print "range x-y" here.


>+	}
>+
>+	if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_SRC, &range)
>+	    == 0) {
>+		flower_print_port_range("src_port_min",
>+					tb[range.min_port_type]);
>+		flower_print_port_range("src_port_max",
>+					tb[range.max_port_type]);
>+	}
>+
> 	flower_print_tcp_flags("tcp_flags", tb[TCA_FLOWER_KEY_TCP_FLAGS],
> 			       tb[TCA_FLOWER_KEY_TCP_FLAGS_MASK]);
> 
>

  reply	other threads:[~2018-10-18 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 13:54 [iproute2 PATCH] tc: flower: Classify packets based port ranges Amritha Nambiar
2018-10-18 12:21 ` Jiri Pirko [this message]
2018-10-18 18:25   ` Nambiar, Amritha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018122136.GB4558@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=amritha.nambiar@intel.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox