Re: [iproute2 PATCH] tc: flower: Classify packets based port ranges

["Nambiar, Amritha" <amritha.nambiar@intel.com>]

On 10/18/2018 5:21 AM, Jiri Pirko wrote:
> Fri, Oct 12, 2018 at 03:54:42PM CEST, amritha.nambiar@intel.com wrote:
> 
> [...]
> 
>> @@ -1516,6 +1625,22 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
>> 	if (nl_type >= 0)
>> 		flower_print_port("src_port", tb[nl_type]);
>>
>> +	if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_DST, &range)
>> +	    == 0) {
>> +		flower_print_port_range("dst_port_min",
>> +					tb[range.min_port_type]);
>> +		flower_print_port_range("dst_port_max",
>> +					tb[range.max_port_type]);
> 
> The input and output of iproute2 utils, tc included should be in sync.
> So you need to print "range x-y" here.
> 

Agree, will fix in v2. Thanks!

> 
>> +	}
>> +
>> +	if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_SRC, &range)
>> +	    == 0) {
>> +		flower_print_port_range("src_port_min",
>> +					tb[range.min_port_type]);
>> +		flower_print_port_range("src_port_max",
>> +					tb[range.max_port_type]);
>> +	}
>> +
>> 	flower_print_tcp_flags("tcp_flags", tb[TCA_FLOWER_KEY_TCP_FLAGS],
>> 			       tb[TCA_FLOWER_KEY_TCP_FLAGS_MASK]);
>>
>>