* [PATCH] net: ethernet: lpc_eth: remove unused local variable
@ 2018-10-18 23:06 Vladimir Zapolskiy
2018-10-20 0:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2018-10-18 23:06 UTC (permalink / raw)
To: David S. Miller; +Cc: Sylvain Lemieux, netdev
A trivial change which removes an unused local variable, the issue
is reported as a compile time warning:
drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_drv_probe':
drivers/net/ethernet/nxp/lpc_eth.c:1250:21: warning: variable 'phydev' set but not used [-Wunused-but-set-variable]
struct phy_device *phydev;
^~~~~~
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
drivers/net/ethernet/nxp/lpc_eth.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index 922b5b5b5c01..e275d64007af 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -1245,7 +1245,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
struct resource *res;
struct net_device *ndev;
struct netdata_local *pldat;
- struct phy_device *phydev;
dma_addr_t dma_handle;
int irq, ret;
u32 tmp;
@@ -1411,8 +1410,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
netdev_info(ndev, "LPC mac at 0x%08x irq %d\n",
res->start, ndev->irq);
- phydev = ndev->phydev;
-
device_init_wakeup(&pdev->dev, 1);
device_set_wakeup_enable(&pdev->dev, 0);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: ethernet: lpc_eth: remove unused local variable
2018-10-18 23:06 [PATCH] net: ethernet: lpc_eth: remove unused local variable Vladimir Zapolskiy
@ 2018-10-20 0:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-20 0:05 UTC (permalink / raw)
To: vz; +Cc: slemieux.tyco, netdev
From: Vladimir Zapolskiy <vz@mleia.com>
Date: Fri, 19 Oct 2018 02:06:53 +0300
> A trivial change which removes an unused local variable, the issue
> is reported as a compile time warning:
>
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_drv_probe':
> drivers/net/ethernet/nxp/lpc_eth.c:1250:21: warning: variable 'phydev' set but not used [-Wunused-but-set-variable]
> struct phy_device *phydev;
> ^~~~~~
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-20 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 23:06 [PATCH] net: ethernet: lpc_eth: remove unused local variable Vladimir Zapolskiy
2018-10-20 0:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox