From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: Shahed.Shaikh@cavium.com, sucheta.chakraborty@qlogic.com,
manish.chopra@cavium.com, Dept-GELinuxNICDev@cavium.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] qlcnic: fix a return in qlcnic_dcb_get_capability()
Date: Mon, 22 Oct 2018 19:34:45 -0700 (PDT) [thread overview]
Message-ID: <20181022.193445.1141993426806484413.davem@davemloft.net> (raw)
In-Reply-To: <20181019201111.xwetmozyy46xd3pg@kili.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 19 Oct 2018 23:11:11 +0300
> These functions are supposed to return one on failure and zero on
> success. Returning a zero here could cause uninitialized variable
> bugs in several of the callers. For example:
>
> drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
> error: uninitialized symbol 'caps'.
>
> Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
prev parent reply other threads:[~2018-10-23 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 20:11 [PATCH net] qlcnic: fix a return in qlcnic_dcb_get_capability() Dan Carpenter
2018-10-23 2:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022.193445.1141993426806484413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=Shahed.Shaikh@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox