From: Stephen Hemminger <stephen@networkplumber.org>
To: Tobias Jungel <tobias.jungel@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2 PATCH] bridge: fix vlan show stats formatting
Date: Mon, 22 Oct 2018 10:00:01 -0700 [thread overview]
Message-ID: <20181022100001.3413fe1c@xeon-e3> (raw)
In-Reply-To: <09b37bb3d091567c1f8958994e69e1221a61c0dc.camel@gmail.com>
On Sat, 20 Oct 2018 15:42:33 +0200
Tobias Jungel <tobias.jungel@gmail.com> wrote:
> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
>
> Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
This patch causes new warning:
CC vlan.o
vlan.c: In function ‘print_vlan_stats_attr’:
vlan.c:492:2: warning: ‘ifname’ may be used uninitialized in this function [-Wmaybe-uninitialized]
print_color_string(PRINT_FP, COLOR_IFNAME,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NULL, "%-16s", ifname);
~~~~~~~~~~~~~~~~~~~~~~
Reverting the patch, please fix and resubmit.
next prev parent reply other threads:[~2018-10-23 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 13:42 [iproute2 PATCH] bridge: fix vlan show stats formatting Tobias Jungel
2018-10-22 16:47 ` Stephen Hemminger
2018-10-22 17:00 ` Stephen Hemminger [this message]
2018-10-26 21:51 ` [iproute2 PATCH v2] " Tobias Jungel
2018-10-29 16:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022100001.3413fe1c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=tobias.jungel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox