From: David Miller <davem@davemloft.net>
To: rahul.verma@cavium.com
Cc: netdev@vger.kernel.org, Ariel.Elior@cavium.com,
Dept-EngEverestLinuxL2@cavium.com
Subject: Re: [PATCH net 1/1] qed: Fix static checker warning
Date: Tue, 23 Oct 2018 11:05:56 -0700 (PDT) [thread overview]
Message-ID: <20181023.110556.1689477118069474659.davem@davemloft.net> (raw)
In-Reply-To: <20181023150424.6046-1-rahul.verma@cavium.com>
From: Rahul Verma <rahul.verma@cavium.com>
Date: Tue, 23 Oct 2018 08:04:24 -0700
> From: Rahul Verma <Rahul.Verma@cavium.com>
>
> Static Checker Warnings:
> drivers/net/ethernet/qlogic/qed/qed_main.c:1510 qed_fill_link_capability()
> error: uninitialized symbol 'tcvr_state'.
> drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
> error: uninitialized symbol 'transceiver_state'.
> drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
> error: uninitialized symbol 'transceiver_type'.
>
> Symbols tcvr_state, transceiver_state and transceiver_type
> are initialized with respective default state.
>
> Fixes: c56a8be7e7aa (qed: Add supported link and advertise link to display in ethtool.)
Referenced commits shall be of the form:
SHA1_ID ("Commit header text.")
Meaning that text must be contained inside of parenthesis and also double quotes.
Please do not forget the double quotes in the future.
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Rahul Verma <Rahul.Verma@cavium.com>
Fixed, and applied.
Thanks.
prev parent reply other threads:[~2018-10-24 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 15:04 [PATCH net 1/1] qed: Fix static checker warning Rahul Verma
2018-10-23 18:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023.110556.1689477118069474659.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@cavium.com \
--cc=Dept-EngEverestLinuxL2@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.verma@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox