From: David Miller <davem@davemloft.net>
To: sudarsana.kalluru@cavium.com
Cc: netdev@vger.kernel.org, Michal.Kalderon@cavium.com
Subject: Re: [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.
Date: Fri, 09 Nov 2018 15:22:02 -0800 (PST) [thread overview]
Message-ID: <20181109.152202.1670898351591745529.davem@davemloft.net> (raw)
In-Reply-To: <20181109101043.22373-1-sudarsana.kalluru@cavium.com>
From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
Date: Fri, 9 Nov 2018 02:10:43 -0800
> +/* Following is the DMAE channel number allocation for the clients.
> + * MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively.
> + * Driver: 0-3 and 8-11 (for PF dmae operations)
> + * 4 and 12 (for stats requests)
> + */
> +#define BNX2X_FW_DMAE_C 13 /* Channel for FW DMAE operations */
...
> + start_params->dmae_cmd_id = BNX2X_FW_DMAE_C;
Why do you need this, it never changes, and:
> + rdata->dmae_cmd_id = start_params->dmae_cmd_id;
It always is the same value here in the one place it is used.
Just assign BNX2X_FW_DMAE_C directly to rdata->dmae_cmd_id please.
prev parent reply other threads:[~2018-11-10 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 10:10 [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions Sudarsana Reddy Kalluru
2018-11-09 23:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109.152202.1670898351591745529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Michal.Kalderon@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=sudarsana.kalluru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox