From: Quentin Monnet <quentin.monnet@netronome.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: [PATCH bpf-next 0/9] bpf: pass device ops as callbacks and remove some ndo_bpf subcommands
Date: Fri, 9 Nov 2018 13:03:23 +0000 [thread overview]
Message-ID: <20181109130332.27576-1-quentin.monnet@netronome.com> (raw)
For passing device functions for offloaded eBPF programs, there used to
be no place where to store the pointer without making the non-offloaded
programs pay a memory price.
As a consequence, three functions were called with ndo_bpf() through
specific commands. Now that we have struct bpf_offload_dev, and since none
of those operations rely on RTNL, we can turn these three commands into
hooks inside the struct bpf_prog_offload_ops, and pass them as part of
bpf_offload_dev_create().
This patch set changes the offload architecture to do so, and brings the
relevant changes to the nfp and netdevsim drivers.
Quentin Monnet (9):
nfp: bpf: move nfp_bpf_analyzer_ops from verifier.c to offload.c
bpf: pass a struct with offload callbacks to bpf_offload_dev_create()
bpf: call verify_insn from its callback in struct bpf_offload_dev
bpf: call finalize() from its callback in struct bpf_offload_dev
bpf: call verifier_prep from its callback in struct bpf_offload_dev
bpf: pass translate() as a callback and remove its ndo_bpf subcommand
bpf: pass destroy() as a callback and remove its ndo_bpf subcommand
bpf: pass prog instead of env to bpf_prog_offload_verifier_prep()
bpf: do not pass netdev to translate() and prepare() offload callbacks
drivers/net/ethernet/netronome/nfp/bpf/main.c | 2 +-
drivers/net/ethernet/netronome/nfp/bpf/main.h | 6 +-
.../net/ethernet/netronome/nfp/bpf/offload.c | 34 ++++-----
.../net/ethernet/netronome/nfp/bpf/verifier.c | 11 +--
drivers/net/netdevsim/bpf.c | 51 +++++++------
include/linux/bpf.h | 8 +-
include/linux/bpf_verifier.h | 2 +-
include/linux/netdevice.h | 12 ---
kernel/bpf/offload.c | 75 +++++++------------
kernel/bpf/verifier.c | 2 +-
10 files changed, 85 insertions(+), 118 deletions(-)
--
2.17.1
next reply other threads:[~2018-11-09 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 13:03 Quentin Monnet [this message]
2018-11-09 13:03 ` [PATCH bpf-next 1/9] nfp: bpf: move nfp_bpf_analyzer_ops from verifier.c to offload.c Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 2/9] bpf: pass a struct with offload callbacks to bpf_offload_dev_create() Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 3/9] bpf: call verify_insn from its callback in struct bpf_offload_dev Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 4/9] bpf: call finalize() " Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 5/9] bpf: call verifier_prep " Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 6/9] bpf: pass translate() as a callback and remove its ndo_bpf subcommand Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 7/9] bpf: pass destroy() " Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 8/9] bpf: pass prog instead of env to bpf_prog_offload_verifier_prep() Quentin Monnet
2018-11-09 13:03 ` [PATCH bpf-next 9/9] bpf: do not pass netdev to translate() and prepare() offload callbacks Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109130332.27576-1-quentin.monnet@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox