From: Stanislav Fomichev <sdf@fomichev.me>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org,
quentin.monnet@netronome.com, guro@fb.com,
jiong.wang@netronome.com, sdf@google.com,
bhole_prashant_q7@lab.ntt.co.jp, john.fastabend@gmail.com,
jbenc@redhat.com, treeze.taeung@gmail.com, yhs@fb.com,
osk@fb.com, sandipan@linux.vnet.ibm.com
Subject: Re: [PATCH v4 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin
Date: Fri, 9 Nov 2018 07:41:55 -0800 [thread overview]
Message-ID: <20181109154155.m2zqdylynsk4w4qy@mini-arch> (raw)
In-Reply-To: <20181108193705.2933c2bc@cakuba.netronome.com>
On 11/08, Jakub Kicinski wrote:
> On Thu, 8 Nov 2018 16:22:08 -0800, Stanislav Fomichev wrote:
> > + for (map = bpf_map__prev(map, obj);
> > + map != NULL;
> > + map = bpf_map__prev(map, obj)) {
>
> nit pick: if you need to respin all these for loops on error paths could
> have been more concise while loops
Agreed with everything, will address this one and the other comments in v5.
Thank you for another thorough review!
next prev parent reply other threads:[~2018-11-10 1:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 0:22 [PATCH v4 bpf-next 0/7] bpftool: support loading flow dissector Stanislav Fomichev
2018-11-09 0:22 ` [PATCH v4 bpf-next 1/7] selftests/bpf: rename flow dissector section to flow_dissector Stanislav Fomichev
2018-11-09 0:22 ` [PATCH v4 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin Stanislav Fomichev
2018-11-09 3:37 ` Jakub Kicinski
2018-11-09 15:41 ` Stanislav Fomichev [this message]
2018-11-09 0:22 ` [PATCH v4 bpf-next 3/7] libbpf: bpf_program__pin: add special case for instances.nr == 1 Stanislav Fomichev
2018-11-09 0:22 ` [PATCH v4 bpf-next 4/7] libbpf: add internal pin_name Stanislav Fomichev
2018-11-09 3:38 ` Jakub Kicinski
2018-11-09 0:22 ` [PATCH v4 bpf-next 5/7] bpftool: add loadall command Stanislav Fomichev
2018-11-09 3:41 ` Jakub Kicinski
2018-11-09 13:29 ` Quentin Monnet
2018-11-09 15:42 ` Stanislav Fomichev
2018-11-09 0:22 ` [PATCH v4 bpf-next 6/7] bpftool: add pinmaps argument to the load/loadall Stanislav Fomichev
2018-11-09 3:43 ` Jakub Kicinski
2018-11-09 0:22 ` [PATCH v4 bpf-next 7/7] bpftool: support loading flow dissector Stanislav Fomichev
2018-11-09 3:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109154155.m2zqdylynsk4w4qy@mini-arch \
--to=sdf@fomichev.me \
--cc=ast@kernel.org \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=jakub.kicinski@netronome.com \
--cc=jbenc@redhat.com \
--cc=jiong.wang@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=osk@fb.com \
--cc=quentin.monnet@netronome.com \
--cc=sandipan@linux.vnet.ibm.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=treeze.taeung@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox