From: David Miller <davem@davemloft.net>
To: denis.bolotin@cavium.com
Cc: netdev@vger.kernel.org, michal.kalderon@cavium.com,
ariel.elior@cavium.com
Subject: Re: [PATCH net 4/4] qed: Fix reading wrong value in loop condition
Date: Sun, 11 Nov 2018 10:26:43 -0800 (PST) [thread overview]
Message-ID: <20181111.102643.1735923349642608264.davem@davemloft.net> (raw)
In-Reply-To: <20181111150500.4345-5-denis.bolotin@cavium.com>
From: Denis Bolotin <denis.bolotin@cavium.com>
Date: Sun, 11 Nov 2018 17:05:00 +0200
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
> index 0f0aba7..aa7504a 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_int.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
> @@ -992,6 +992,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
> */
> do {
> index = p_sb_attn->sb_index;
> + /* finish reading index before the loop condition */
> + rmb();
Please use dma_rmb().
prev parent reply other threads:[~2018-11-12 4:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 15:04 [PATCH net 0/4] qed: Miscellaneous bug fixes Denis Bolotin
2018-11-11 15:04 ` [PATCH net 1/4] qed: Fix PTT leak in qed_drain() Denis Bolotin
2018-11-11 15:04 ` [PATCH net 2/4] qed: Fix overriding offload_tc by protocols without APP TLV Denis Bolotin
2018-11-11 15:04 ` [PATCH net 3/4] qed: Fix rdma_info structure allocation Denis Bolotin
2018-11-11 15:05 ` [PATCH net 4/4] qed: Fix reading wrong value in loop condition Denis Bolotin
2018-11-11 18:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181111.102643.1735923349642608264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariel.elior@cavium.com \
--cc=denis.bolotin@cavium.com \
--cc=michal.kalderon@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox