From: David Miller <davem@davemloft.net>
To: xuechaojing@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
wulike1@huawei.com, chiqijun@huawei.com, fy.wang@huawei.com,
tony.qu@huawei.com, luoshaokai@huawei.com
Subject: Re: [PATCH 1/1] net-next/hinic:fix three problems in HiNIC Driver
Date: Thu, 15 Nov 2018 09:56:22 -0800 (PST) [thread overview]
Message-ID: <20181115.095622.889070618474069350.davem@davemloft.net> (raw)
In-Reply-To: <20181115052327.2859-1-xuechaojing@huawei.com>
From: Xue Chaojing <xuechaojing@huawei.com>
Date: Thu, 15 Nov 2018 05:23:27 +0000
> This patch fixes these problems:
> 1. In order to improve performance, this patch add rx checksum offload
> for the HiNIC driver. Performance test(Iperf) shows more than 95%
> improvement in TCP streams.
> 2. In add_mac_addr(), if the MAC address is a muliticast address, it
> will not be set, which causes the network card fail to receive the
> multicast packet. This patch fixes this bug.
> 3. In rx_alloc_pkts(), there is a loop call of tasklet, which causes
> 100% cpu utilization, even no packets are being received. This patch
> fixes this bug.
>
> Signed-off-by: Xue Chaojing <xuechaojing@huawei.com>
Each patch should do one thing.
Please don't combine multiple changes into one patch like this.
Post a proper patches series, one change per patch, with a proper
"[PATCH 0/N] " header posting preceeding the series.
Thanks.
prev parent reply other threads:[~2018-11-15 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 5:23 [PATCH 1/1] net-next/hinic:fix three problems in HiNIC Driver Xue Chaojing
2018-11-15 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115.095622.889070618474069350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chiqijun@huawei.com \
--cc=fy.wang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshaokai@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=tony.qu@huawei.com \
--cc=wulike1@huawei.com \
--cc=xuechaojing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox