Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, jiri@resnulli.us,
	xiyou.wangcong@gmail.com, jhs@mojatatu.com,
	oss-drivers@netronome.com,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes
Date: Wed, 14 Nov 2018 22:23:44 -0800	[thread overview]
Message-ID: <20181115062351.22763-1-jakub.kicinski@netronome.com> (raw)

Hi!

This series updates the GRED Qdisc.  The Qdisc matches nfp offload very
well, but before we can offload it there are a number of improvements
to make.

First few patches add extack messages to the Qdisc and pass extack
to netlink validation.

Next a new netlink attribute group is added, to allow GRED to be
extended more easily.  Currently GRED passes C structures as attributes,
and even an array of C structs for virtual queue configuration.  User
space has hard coded the expected length of that array, so adding new
fields is not possible.

New two-level attribute group is added:

  [TCA_GRED_VQ_LIST]
    [TCA_GRED_VQ_ENTRY]
      [TCA_GRED_VQ_DP]
      [TCA_GRED_VQ_FLAGS]
      [TCA_GRED_VQ_STAT_*]
    [TCA_GRED_VQ_ENTRY]
      [TCA_GRED_VQ_DP]
      [TCA_GRED_VQ_FLAGS]
      [TCA_GRED_VQ_STAT_*]
    [TCA_GRED_VQ_ENTRY]
       ...

Statistics are dump only. Patch 4 switches the byte counts to be 64 bit,
and patch 5 introduces the new stats attributes for dump.  Patch 6
switches RED flags to be per-virtual queue, and patch 7 allows them
to be dumped and set at virtual queue granularity.


Jakub Kicinski (7):
  net: sched: gred: separate error and non-error path in gred_change()
  net: sched: gred: pass extack to nla_parse_nested()
  net: sched: gred: use extack to provide more details on configuration
    errors
  net: sched: gred: store bytesin as a 64 bit value
  net: sched: gred: provide a better structured dump and expose stats
  net: sched: gred: store red flags per virtual queue
  net: sched: gred: allow manipulating per-DP RED flags

 include/uapi/linux/pkt_sched.h |  27 ++++
 net/sched/sch_gred.c           | 281 +++++++++++++++++++++++++++++----
 2 files changed, 281 insertions(+), 27 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-11-15 16:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  6:23 Jakub Kicinski [this message]
2018-11-15  6:23 ` [PATCH net-next 1/7] net: sched: gred: separate error and non-error path in gred_change() Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 2/7] net: sched: gred: pass extack to nla_parse_nested() Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 3/7] net: sched: gred: use extack to provide more details on configuration errors Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 4/7] net: sched: gred: store bytesin as a 64 bit value Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 5/7] net: sched: gred: provide a better structured dump and expose stats Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 6/7] net: sched: gred: store red flags per virtual queue Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 7/7] net: sched: gred: allow manipulating per-DP RED flags Jakub Kicinski
2018-11-17  7:19 ` [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115062351.22763-1-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox