Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, jiri@resnulli.us,
	xiyou.wangcong@gmail.com, jhs@mojatatu.com,
	oss-drivers@netronome.com,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH net-next 4/7] net: sched: gred: store bytesin as a 64 bit value
Date: Wed, 14 Nov 2018 22:23:48 -0800	[thread overview]
Message-ID: <20181115062351.22763-5-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20181115062351.22763-1-jakub.kicinski@netronome.com>

32 bit counters for bytes are not really going to last long in modern
world.  Make sch_gred count bytes on a 64 bit counter.  It will still
get truncated during dump but follow up patch will add set of new
stat dump attributes.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
---
 net/sched/sch_gred.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
index 3d7bd374b303..6f209c83ee7a 100644
--- a/net/sched/sch_gred.c
+++ b/net/sched/sch_gred.c
@@ -35,7 +35,7 @@ struct gred_sched;
 struct gred_sched_data {
 	u32		limit;		/* HARD maximal queue length	*/
 	u32		DP;		/* the drop parameters */
-	u32		bytesin;	/* bytes seen on virtualQ so far*/
+	u64		bytesin;	/* bytes seen on virtualQ so far*/
 	u32		packetsin;	/* packets seen on virtualQ so far*/
 	u32		backlog;	/* bytes on the virtualQ */
 	u8		prio;		/* the prio of this vq */
-- 
2.17.1

  parent reply	other threads:[~2018-11-15 16:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  6:23 [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 1/7] net: sched: gred: separate error and non-error path in gred_change() Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 2/7] net: sched: gred: pass extack to nla_parse_nested() Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 3/7] net: sched: gred: use extack to provide more details on configuration errors Jakub Kicinski
2018-11-15  6:23 ` Jakub Kicinski [this message]
2018-11-15  6:23 ` [PATCH net-next 5/7] net: sched: gred: provide a better structured dump and expose stats Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 6/7] net: sched: gred: store red flags per virtual queue Jakub Kicinski
2018-11-15  6:23 ` [PATCH net-next 7/7] net: sched: gred: allow manipulating per-DP RED flags Jakub Kicinski
2018-11-17  7:19 ` [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115062351.22763-5-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox