From: David Miller <davem@davemloft.net>
To: tanxiaojun@huawei.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
lipeng321@huawei.com, linyunsheng@huawei.com,
shenjian15@huawei.com, tanhuazhong@huawei.com,
liangfuyun1@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: hns3: add common validation in hclge_dcb
Date: Mon, 19 Nov 2018 18:32:24 -0800 (PST) [thread overview]
Message-ID: <20181119.183224.87651627805917399.davem@davemloft.net> (raw)
In-Reply-To: <1542632535-18210-1-git-send-email-tanxiaojun@huawei.com>
From: Tan Xiaojun <tanxiaojun@huawei.com>
Date: Mon, 19 Nov 2018 21:02:15 +0800
> From: Yunsheng Lin <linyunsheng@huawei.com>
>
> Before setting tm related configuration to hardware, driver
> needs to check the configuration provided by user is valid.
> Currently hclge_ieee_setets and hclge_setup_tc both implement
> their own checking, which has a lot in common.
>
> This patch addes hclge_dcb_common_validate to do the common
> checking. The checking in hclge_tm_prio_tc_info_update
> and hclge_tm_schd_info_update is unnecessary now, so change
> the return type to void, which removes the need to do error
> handling when one of the checking fails.
>
> Also, ets->prio_tc is indexed by user prio and ets->tc_tsa is
> indexed by tc num, so this patch changes them to use different
> index.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
Looks good, applied, thanks!
prev parent reply other threads:[~2018-11-20 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 13:02 [PATCH net-next] net: hns3: add common validation in hclge_dcb Tan Xiaojun
2018-11-20 1:50 ` Yunsheng Lin
2018-11-20 2:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119.183224.87651627805917399.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=liangfuyun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=tanxiaojun@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox