Netdev List
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: Pavel Balaev <mail@void.so>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] ipv4: make DSCP values works with ip rules
Date: Tue, 20 Nov 2018 15:12:18 +0100	[thread overview]
Message-ID: <20181120141218.GA3474@bistromath.localdomain> (raw)
In-Reply-To: <20181120132927.GA4987@rnd.infotecs.ru>

Hi Pavel,

2018-11-20, 16:29:36 +0300, Pavel Balaev wrote:
> This patch adds ability to set DSCP values in ip rules.

You dropped the RFC reference that you had in v1.

> Values presented in /etc/iproute3/rt_dsfield and now can be used in rules.

iproute3?

> 
> Example:
> $ ip ru add from 10.88.0.2 tos AF23 lookup dscp.
> Result:
> ---

Be careful when you write commit messages. "git am" is going to cut
out everything that comes after the first ^---$ line it sees, so the
rest of those explanations, as well as your sign-off, will be dropped.

> 32762:	from 10.88.0.2 tos AF43 lookup dscp
> ---
> 
> Patch was tested with such configuration:
> 
> +-----------+
> | 10.88.0.2 | -> ping 172.16.0.1 -Q 0x58 ->
> |   host0   |
> +-----------+
> 
>    +-------------------------------------+
>    | router with patched kernel          |
>    |                                     |
> -> | from 10.88.0.2 tos AF43 lookup dscp |->
>    | table dscp:                         |
>    |   172.16.0.0/24 via 10.200.0.2      |
>    +-------------------------------------+
> 
> 	 +------------------+
> -> | eth0: 10.200.0.2 |
>    | eth1: 172.16.0.1 |
>    |      host1       |
>    +------------------+
> 
> Signed-off-by: Pavel Balaev <mail@void.so>

-- 
Sabrina

  reply	other threads:[~2018-11-21  0:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 13:29 [PATCH v2] ipv4: make DSCP values works with ip rules Pavel Balaev
2018-11-20 14:12 ` Sabrina Dubroca [this message]
2018-11-20 14:36   ` Pavel Balaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120141218.GA3474@bistromath.localdomain \
    --to=sd@queasysnail.net \
    --cc=davem@davemloft.net \
    --cc=mail@void.so \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox