Re: [PATCH v2] ipv4: make DSCP values works with ip rules

[Pavel Balaev <mail@void.so>]

On Tue, Nov 20, 2018 at 03:12:18PM +0100, Sabrina Dubroca wrote:
> Hi Pavel,
> 
> 2018-11-20, 16:29:36 +0300, Pavel Balaev wrote:
> > This patch adds ability to set DSCP values in ip rules.
> 
> You dropped the RFC reference that you had in v1.
> 
RFC2474 and RFC2597 values.
> > Values presented in /etc/iproute3/rt_dsfield and now can be used in rules.
> 
> iproute3?
> 
That was a typo, iproute2.
> > 
> > Example:
> > $ ip ru add from 10.88.0.2 tos AF23 lookup dscp.
> > Result:
> > ---
> 
> Be careful when you write commit messages. "git am" is going to cut
> out everything that comes after the first ^---$ line it sees, so the
> rest of those explanations, as well as your sign-off, will be dropped.
> 
> > 32762:	from 10.88.0.2 tos AF43 lookup dscp
> > ---
> > 
> > Patch was tested with such configuration:
> > 
> > +-----------+
> > | 10.88.0.2 | -> ping 172.16.0.1 -Q 0x58 ->
> > |   host0   |
> > +-----------+
> > 
> >    +-------------------------------------+
> >    | router with patched kernel          |
> >    |                                     |
> > -> | from 10.88.0.2 tos AF43 lookup dscp |->
> >    | table dscp:                         |
> >    |   172.16.0.0/24 via 10.200.0.2      |
> >    +-------------------------------------+
> > 
> > 	 +------------------+
> > -> | eth0: 10.200.0.2 |
> >    | eth1: 172.16.0.1 |
> >    |      host1       |
> >    +------------------+
> > 
> > Signed-off-by: Pavel Balaev <mail@void.so>
> 
> -- 
> Sabrina
Ok. Got it. Tnx.