From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 5/6] ixgbe: Replace synchronize_sched() with synchronize_rcu()
Date: Wed, 21 Nov 2018 11:54:22 -0800 [thread overview]
Message-ID: <20181121195423.20509-6-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20181121195423.20509-1-jeffrey.t.kirsher@intel.com>
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
Now that synchronize_rcu() waits for preempt-disable regions of code
as well as RCU read-side critical sections, synchronize_sched() can be
replaced by synchronize_rcu(). This commit therefore makes this change.
Signed-off-by: "Paul E. McKenney" <paulmck@linux.ibm.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index cfb83687c3d8..49a4ea38eb07 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -6077,9 +6077,9 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
/* Disable Rx */
ixgbe_disable_rx(adapter);
- /* synchronize_sched() needed for pending XDP buffers to drain */
+ /* synchronize_rcu() needed for pending XDP buffers to drain */
if (adapter->xdp_ring[0])
- synchronize_sched();
+ synchronize_rcu();
ixgbe_irq_disable(adapter);
@@ -10476,7 +10476,7 @@ void ixgbe_txrx_ring_disable(struct ixgbe_adapter *adapter, int ring)
ixgbe_disable_rxr_hw(adapter, rx_ring);
if (xdp_ring)
- synchronize_sched();
+ synchronize_rcu();
/* Rx/Tx/XDP Tx share the same napi context. */
napi_disable(&rx_ring->q_vector->napi);
--
2.19.1
next prev parent reply other threads:[~2018-11-22 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 19:54 [net-next 0/6][pull request] Intel Wired LAN Driver Updates 2018-11-21 Jeff Kirsher
2018-11-21 19:54 ` [net-next 1/6] ixgbe: add ipsec hw offload note to ixgbe Documentation Jeff Kirsher
2018-11-21 19:54 ` [net-next 2/6] igb: Fix format with line continuation whitespace Jeff Kirsher
2018-11-21 19:54 ` [net-next 3/6] docs-networking: fix typo in define Jeff Kirsher
2018-11-21 19:54 ` [net-next 4/6] ethernet/intel: consolidate NAPI and NAPI exit Jeff Kirsher
2018-11-21 19:54 ` Jeff Kirsher [this message]
2018-11-21 19:54 ` [net-next 6/6] igc: Remove obsolete IGC_ERR define Jeff Kirsher
2018-11-23 19:34 ` [net-next 0/6][pull request] Intel Wired LAN Driver Updates 2018-11-21 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121195423.20509-6-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=paulmck@linux.ibm.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox