From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Sasha Neftin <sasha.neftin@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 6/6] igc: Remove obsolete IGC_ERR define
Date: Wed, 21 Nov 2018 11:54:23 -0800 [thread overview]
Message-ID: <20181121195423.20509-7-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20181121195423.20509-1-jeffrey.t.kirsher@intel.com>
From: Sasha Neftin <sasha.neftin@intel.com>
Address community comment.
Remove obsolete IGC_ERR define and use dev_err method.
Suggested by Joe Perches.
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/igc/igc.h | 2 --
drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index 3b00b109b34a..b1039dd3dd13 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -11,8 +11,6 @@
#include <linux/ethtool.h>
#include <linux/sctp.h>
-#define IGC_ERR(args...) pr_err("igc: " args)
-
#include "igc_hw.h"
/* main */
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 28ffe98f8921..f20183037fb2 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -3535,7 +3535,7 @@ static int igc_probe(struct pci_dev *pdev,
err = dma_set_coherent_mask(&pdev->dev,
DMA_BIT_MASK(32));
if (err) {
- IGC_ERR("Wrong DMA configuration, aborting\n");
+ dev_err(&pdev->dev, "igc: Wrong DMA config\n");
goto err_dma;
}
}
--
2.19.1
next prev parent reply other threads:[~2018-11-22 6:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 19:54 [net-next 0/6][pull request] Intel Wired LAN Driver Updates 2018-11-21 Jeff Kirsher
2018-11-21 19:54 ` [net-next 1/6] ixgbe: add ipsec hw offload note to ixgbe Documentation Jeff Kirsher
2018-11-21 19:54 ` [net-next 2/6] igb: Fix format with line continuation whitespace Jeff Kirsher
2018-11-21 19:54 ` [net-next 3/6] docs-networking: fix typo in define Jeff Kirsher
2018-11-21 19:54 ` [net-next 4/6] ethernet/intel: consolidate NAPI and NAPI exit Jeff Kirsher
2018-11-21 19:54 ` [net-next 5/6] ixgbe: Replace synchronize_sched() with synchronize_rcu() Jeff Kirsher
2018-11-21 19:54 ` Jeff Kirsher [this message]
2018-11-23 19:34 ` [net-next 0/6][pull request] Intel Wired LAN Driver Updates 2018-11-21 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121195423.20509-7-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox