Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lorenzo.bianconi@redhat.com
Cc: netdev@vger.kernel.org, Sunil.Goutham@cavium.com
Subject: Re: [PATCH net] net: thunderx: set tso_hdrs pointer to NULL in nicvf_free_snd_queue
Date: Fri, 23 Nov 2018 22:33:34 -0800 (PST)	[thread overview]
Message-ID: <20181123.223334.1969691917725314747.davem@davemloft.net> (raw)
In-Reply-To: <6334938109def4dc5ead5ff1ae66e2d37c9bc595.1542993848.git.lorenzo.bianconi@redhat.com>

From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date: Fri, 23 Nov 2018 18:28:01 +0100

> Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine
> since it is used to check if tso dma descriptor queue has been previously
> allocated. The issue can be triggered with the following reproducer:
> 
> $ip link set dev enP2p1s0v0 xdpdrv obj xdp_dummy.o
> $ip link set dev enP2p1s0v0 xdpdrv off
 ...
> where xdp_dummy.c is a simple bpf program that forwards the incoming
> frames to the network stack (available here:
> https://github.com/altoor/xdp_walkthrough_examples/blob/master/sample_1/xdp_dummy.c)
> 
> Fixes: 05c773f52b96 ("net: thunderx: Add basic XDP support")
> Fixes: 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller")
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Applied and queued up for -stable, but please in the future:

1) Do not break up long "Fixes: " tag lines, it must be keep as a single
   uninterrupted line for grep'ability etc.

2) Do not put an empty line between "Fixes: " and other tags.  All tags
   are equal, and appear in a straight uninterrupted sequence of lines.

Thank you.

  reply	other threads:[~2018-11-24 17:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1542993848.git.lorenzo.bianconi@redhat.com>
2018-11-23 17:28 ` [PATCH net] net: thunderx: set tso_hdrs pointer to NULL in nicvf_free_snd_queue Lorenzo Bianconi
2018-11-24  6:33   ` David Miller [this message]
2018-11-24  8:35     ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123.223334.1969691917725314747.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Sunil.Goutham@cavium.com \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox