* [PATCH iproute2] tc: add a missing space between rate estimator and backlog
@ 2018-11-30 13:57 Eric Dumazet
2018-12-01 8:31 ` Jiri Pirko
2018-12-03 22:37 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-11-30 13:57 UTC (permalink / raw)
To: David Ahern, Stephen Hemminger
Cc: netdev, Eric Dumazet, Eric Dumazet, Jiri Pirko
When a rate estimator is active, "tc -s qd" displays
something like :
rate 12616bit 11ppsbacklog 0b 0p requeues 2
instead of :
rate 12616bit 11pps backlog 0b 0p requeues 2
Fixes: 4fcec7f3665b ("tc: jsonify stats2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jiri Pirko <jiri@mellanox.com>
---
tc/tc_util.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tc/tc_util.c b/tc/tc_util.c
index 82856a85170b6fdb2dfab42a8487882afbf6c93d..ab717890bb2a44b4c53a756bd8350b4ed4428a22 100644
--- a/tc/tc_util.c
+++ b/tc/tc_util.c
@@ -838,8 +838,9 @@ void print_tcstats2_attr(FILE *fp, struct rtattr *rta, char *prefix, struct rtat
memcpy(&q, RTA_DATA(tbs[TCA_STATS_QUEUE]), MIN(RTA_PAYLOAD(tbs[TCA_STATS_QUEUE]), sizeof(q)));
if (!tbs[TCA_STATS_RATE_EST])
- print_string(PRINT_FP, NULL, "\n%s", prefix);
+ print_string(PRINT_FP, NULL, "\n", "");
print_uint(PRINT_JSON, "backlog", NULL, q.backlog);
+ print_string(PRINT_FP, NULL, "%s", prefix);
print_string(PRINT_FP, NULL, "backlog %s",
sprint_size(q.backlog, b1));
print_uint(PRINT_ANY, "qlen", " %up", q.qlen);
--
2.20.0.rc1.387.gf8505762e3-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] tc: add a missing space between rate estimator and backlog
2018-11-30 13:57 [PATCH iproute2] tc: add a missing space between rate estimator and backlog Eric Dumazet
@ 2018-12-01 8:31 ` Jiri Pirko
2018-12-03 22:37 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2018-12-01 8:31 UTC (permalink / raw)
To: Eric Dumazet
Cc: David Ahern, Stephen Hemminger, netdev, Eric Dumazet, Jiri Pirko
Fri, Nov 30, 2018 at 02:57:02PM CET, edumazet@google.com wrote:
>When a rate estimator is active, "tc -s qd" displays
>something like :
>
>rate 12616bit 11ppsbacklog 0b 0p requeues 2
>
>instead of :
>
>rate 12616bit 11pps backlog 0b 0p requeues 2
>
>Fixes: 4fcec7f3665b ("tc: jsonify stats2")
>Signed-off-by: Eric Dumazet <edumazet@google.com>
>Cc: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] tc: add a missing space between rate estimator and backlog
2018-11-30 13:57 [PATCH iproute2] tc: add a missing space between rate estimator and backlog Eric Dumazet
2018-12-01 8:31 ` Jiri Pirko
@ 2018-12-03 22:37 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2018-12-03 22:37 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Ahern, netdev, Eric Dumazet, Jiri Pirko
On Fri, 30 Nov 2018 05:57:02 -0800
Eric Dumazet <edumazet@google.com> wrote:
> When a rate estimator is active, "tc -s qd" displays
> something like :
>
> rate 12616bit 11ppsbacklog 0b 0p requeues 2
>
> instead of :
>
> rate 12616bit 11pps backlog 0b 0p requeues 2
>
> Fixes: 4fcec7f3665b ("tc: jsonify stats2")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jiri Pirko <jiri@mellanox.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-03 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-30 13:57 [PATCH iproute2] tc: add a missing space between rate estimator and backlog Eric Dumazet
2018-12-01 8:31 ` Jiri Pirko
2018-12-03 22:37 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox