* [PATCH][next] neighbour: remove stray semicolon
@ 2018-12-20 16:50 Colin King
2018-12-20 16:56 ` Roopa Prabhu
2018-12-21 0:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-12-20 16:50 UTC (permalink / raw)
To: David S . Miller, David Ahern, Roopa Prabhu, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the stray semicolon means that the final term in the addition
is being missed. Fix this by removing it. Cleans up clang warning:
net/core/neighbour.c:2821:9: warning: expression result unused [-Wunused-value]
Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/core/neighbour.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 43687c9abe1d..1c4b7814ac32 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2817,7 +2817,7 @@ static int neigh_get_reply(struct net *net, struct neighbour *neigh,
static inline size_t pneigh_nlmsg_size(void)
{
return NLMSG_ALIGN(sizeof(struct ndmsg))
- + nla_total_size(MAX_ADDR_LEN); /* NDA_DST */
+ + nla_total_size(MAX_ADDR_LEN) /* NDA_DST */
+ nla_total_size(1); /* NDA_PROTOCOL */
}
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] neighbour: remove stray semicolon
2018-12-20 16:50 [PATCH][next] neighbour: remove stray semicolon Colin King
@ 2018-12-20 16:56 ` Roopa Prabhu
2018-12-21 0:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Roopa Prabhu @ 2018-12-20 16:56 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, David Ahern, netdev, kernel-janitors,
Linux Kernel Mailing List
On Thu, Dec 20, 2018 at 8:50 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the stray semicolon means that the final term in the addition
> is being missed. Fix this by removing it. Cleans up clang warning:
>
> net/core/neighbour.c:2821:9: warning: expression result unused [-Wunused-value]
>
> Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-By: Roopa Prabhu <roopa@cumulusnetworks.com>
Thanks!.
> ---
> net/core/neighbour.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 43687c9abe1d..1c4b7814ac32 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -2817,7 +2817,7 @@ static int neigh_get_reply(struct net *net, struct neighbour *neigh,
> static inline size_t pneigh_nlmsg_size(void)
> {
> return NLMSG_ALIGN(sizeof(struct ndmsg))
> - + nla_total_size(MAX_ADDR_LEN); /* NDA_DST */
> + + nla_total_size(MAX_ADDR_LEN) /* NDA_DST */
> + nla_total_size(1); /* NDA_PROTOCOL */
> }
>
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] neighbour: remove stray semicolon
2018-12-20 16:50 [PATCH][next] neighbour: remove stray semicolon Colin King
2018-12-20 16:56 ` Roopa Prabhu
@ 2018-12-21 0:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-12-21 0:41 UTC (permalink / raw)
To: colin.king; +Cc: dsahern, roopa, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 20 Dec 2018 16:50:50 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the stray semicolon means that the final term in the addition
> is being missed. Fix this by removing it. Cleans up clang warning:
>
> net/core/neighbour.c:2821:9: warning: expression result unused [-Wunused-value]
>
> Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks Colin.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-21 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-20 16:50 [PATCH][next] neighbour: remove stray semicolon Colin King
2018-12-20 16:56 ` Roopa Prabhu
2018-12-21 0:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox