From: David Miller <davem@davemloft.net>
To: soltys@ziu.info
Cc: netdev@vger.kernel.org, jay.vosburgh@canonical.com,
vincent@bernat.ch, maheshb@google.com, maze@google.com,
chonggangli@google.com
Subject: Re: [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters
Date: Sun, 13 Jan 2019 15:03:55 -0800 (PST) [thread overview]
Message-ID: <20190113.150355.1753998293477839740.davem@davemloft.net> (raw)
In-Reply-To: <20190107162946.13072-2-soltys@ziu.info>
From: Michal Soltys <soltys@ziu.info>
Date: Mon, 7 Jan 2019 17:29:46 +0100
> This patch reverts:
>
> b89f04c61efe bonding: deliver link-local packets with skb->dev set to link that packets arrived on
>
> And its subsequent fixups:
>
> 6a9e461f6fe4 bonding: pass link-local packets to bonding master also.
> 0f3b914c9cfc bonding: fix warning message
>
> The intended functionality of the original patch (as explained by its
> author) has been available in the kernel since v2.6.21-350-g80feaacb8a64
> via PACKET_ORIGDEV socket option. The patch also broke that feature, as
> it's now no longer possible to get the original incoming device. Quoting
> the report:
>
>> Unfortunately, this doesn't completely restore the previous
>> functionality as PACKET_ORIGDEV is broken for the copy: the original
>> interface is lost through the call to netif_rx(). A LLDP daemon
>> listening to the master interface won't get the original interface like
>> it was able to before 4.12.
>
> The patch reverts to pre-b89f04c61efe state, so:
>
> - both master and original (via PACKET_ORIGDEV) devices are available
> when listening on the master
> - original device is available when listening directly on one of its
> slaves
>
> Reported-by: Vincent Bernat <vincent@bernat.ch>
> Signed-off-by: Michal Soltys <soltys@ziu.info>
Google folks I want to hear what you have to say about all of this.
Thank you.
next prev parent reply other threads:[~2019-01-13 23:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 16:29 [PATCH net 0/1] bonding: fix PACKET_ORIGDEV regression Michal Soltys
2019-01-07 16:29 ` [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters Michal Soltys
2019-01-07 17:12 ` David Miller
2019-01-08 13:46 ` Vincent Bernat
2019-01-13 23:03 ` David Miller [this message]
2019-01-14 2:01 ` Maciej Żenczykowski
2019-01-14 8:00 ` Vincent Bernat
2019-01-15 2:19 ` Mahesh Bandewar (महेश बंडेवार)
2019-01-16 2:58 ` Michal Soltys
2019-01-16 2:01 ` Michal Soltys
2019-01-18 0:27 ` Michal Soltys
2019-01-18 6:58 ` Maciej Żenczykowski
2019-01-29 1:47 ` Michal Soltys
2019-01-29 9:39 ` Maciej Żenczykowski
2019-02-18 16:55 ` [PATCH v2] bonding: fix PACKET_ORIGDEV regression Michal Soltys
2019-02-19 1:51 ` David Ahern
2019-02-19 9:14 ` Maciej Żenczykowski
2019-02-21 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113.150355.1753998293477839740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chonggangli@google.com \
--cc=jay.vosburgh@canonical.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=soltys@ziu.info \
--cc=vincent@bernat.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox