From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Davide Caratti <dcaratti@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, u9012063@gmail.com
Subject: Re: [PATCH net] net: ip6_gre: use erspan key field for tunnel lookup
Date: Wed, 16 Jan 2019 17:40:04 +0100 [thread overview]
Message-ID: <20190116164003.GC2454@localhost.localdomain> (raw)
In-Reply-To: <568fc3d4505d6a1725a4e1e59f43f0af0ac10f8c.camel@redhat.com>
>
> hi Lorenzo,
>
> are we sure that 'ershdr' is in the linear part of skb? if not, we might
> need a call to pskb_may_pull() here.
Hi Davide,
thx for the review. I agree, I think we should check erspan header with
pskb_may_pull in gre_parse_header. In this way we can remove the check
in ip6erspan_rcv() and erspan_rcv(). I will fix in v2
Does '((*(u8 *)options & 0xF0) != 0x40)' have the same issue?
Regards,
Lorenzo
>
> thanks!
> --
> davide
>
>
>
next prev parent reply other threads:[~2019-01-16 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1547569872.git.lorenzo.bianconi@redhat.com>
2019-01-15 16:43 ` [PATCH net] net: ip6_gre: use erspan key field for tunnel lookup Lorenzo Bianconi
2019-01-16 9:47 ` Davide Caratti
2019-01-16 16:40 ` Lorenzo Bianconi [this message]
2019-01-16 17:30 ` Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116164003.GC2454@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox