* [v2] net: dpaa2: improve PTP Kconfig option
@ 2019-01-21 6:26 Yangbo Lu
2019-01-21 18:25 ` Richard Cochran
2019-01-23 1:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yangbo Lu @ 2019-01-21 6:26 UTC (permalink / raw)
To: netdev; +Cc: David S . Miller, Richard Cochran, Ioana Ciocoi Radulescu,
Yangbo Lu
Converted to use "imply" instead of "select" for PTP_1588_CLOCK
driver selecting. This could break the hard dependency between
the PTP clock subsystem and ethernet drivers.
This patch also set "default y" for dpaa2 ptp driver building to
provide user an available ptp clock in default.
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
Changes for v2:
- Converted to use imply for PTP_1588_CLOCK.
- Modified commit message.
---
drivers/net/ethernet/freescale/dpaa2/Kconfig | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index 809a155..f6d244c 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -9,8 +9,9 @@ config FSL_DPAA2_ETH
config FSL_DPAA2_PTP_CLOCK
tristate "Freescale DPAA2 PTP Clock"
- depends on FSL_DPAA2_ETH && POSIX_TIMERS
- select PTP_1588_CLOCK
+ depends on FSL_DPAA2_ETH
+ imply PTP_1588_CLOCK
+ default y
help
This driver adds support for using the DPAA2 1588 timer module
as a PTP clock.
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v2] net: dpaa2: improve PTP Kconfig option
2019-01-21 6:26 [v2] net: dpaa2: improve PTP Kconfig option Yangbo Lu
@ 2019-01-21 18:25 ` Richard Cochran
2019-01-23 1:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2019-01-21 18:25 UTC (permalink / raw)
To: Yangbo Lu; +Cc: netdev, David S . Miller, Ioana Ciocoi Radulescu
On Mon, Jan 21, 2019 at 02:26:37PM +0800, Yangbo Lu wrote:
> Converted to use "imply" instead of "select" for PTP_1588_CLOCK
> driver selecting. This could break the hard dependency between
> the PTP clock subsystem and ethernet drivers.
> This patch also set "default y" for dpaa2 ptp driver building to
> provide user an available ptp clock in default.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] net: dpaa2: improve PTP Kconfig option
2019-01-21 6:26 [v2] net: dpaa2: improve PTP Kconfig option Yangbo Lu
2019-01-21 18:25 ` Richard Cochran
@ 2019-01-23 1:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-23 1:38 UTC (permalink / raw)
To: yangbo.lu; +Cc: netdev, richardcochran, ruxandra.radulescu
From: Yangbo Lu <yangbo.lu@nxp.com>
Date: Mon, 21 Jan 2019 14:26:37 +0800
> Converted to use "imply" instead of "select" for PTP_1588_CLOCK
> driver selecting. This could break the hard dependency between
> the PTP clock subsystem and ethernet drivers.
> This patch also set "default y" for dpaa2 ptp driver building to
> provide user an available ptp clock in default.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> Changes for v2:
> - Converted to use imply for PTP_1588_CLOCK.
> - Modified commit message.
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-23 1:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-21 6:26 [v2] net: dpaa2: improve PTP Kconfig option Yangbo Lu
2019-01-21 18:25 ` Richard Cochran
2019-01-23 1:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox