Netdev List
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>, David Ahern <dsahern@gmail.com>
Subject: [Patch iproute2] tc: add performance counters for basic filter
Date: Tue, 22 Jan 2019 22:41:45 -0800	[thread overview]
Message-ID: <20190123064145.26169-1-xiyou.wangcong@gmail.com> (raw)

Sample output:

filter protocol arp pref 49152 basic chain 0
filter protocol arp pref 49152 basic chain 0 handle 0x1  (rule hit 3 success 3)
    action order 1: gact action pass
     random type none pass val 0
     index 1 ref 1 bind 1 installed 81 sec used 4 sec
    Action statistics:
    Sent 126 bytes 3 pkt (dropped 0, overlimits 0 requeues 0)
    backlog 0b 0p requeues 0

Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
 tc/f_basic.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tc/f_basic.c b/tc/f_basic.c
index af98c088..97d43d49 100644
--- a/tc/f_basic.c
+++ b/tc/f_basic.c
@@ -110,6 +110,7 @@ static int basic_print_opt(struct filter_util *qu, FILE *f,
 			   struct rtattr *opt, __u32 handle)
 {
 	struct rtattr *tb[TCA_BASIC_MAX+1];
+	struct tc_basic_pcnt *pf = NULL;
 
 	if (opt == NULL)
 		return 0;
@@ -125,6 +126,19 @@ static int basic_print_opt(struct filter_util *qu, FILE *f,
 			sprint_tc_classid(rta_getattr_u32(tb[TCA_BASIC_CLASSID]), b1));
 	}
 
+	if (tb[TCA_BASIC_PCNT]) {
+		if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT])  < sizeof(*pf)) {
+			fprintf(f, "Broken perf counters\n");
+			return -1;
+		}
+		pf = RTA_DATA(tb[TCA_BASIC_PCNT]);
+	}
+
+	if (show_stats && NULL != pf)
+		fprintf(f, " (rule hit %llu success %llu)",
+			(unsigned long long) pf->rcnt,
+			(unsigned long long) pf->rhit);
+
 	if (tb[TCA_BASIC_EMATCHES])
 		print_ematch(f, tb[TCA_BASIC_EMATCHES]);
 
-- 
2.20.1


             reply	other threads:[~2019-01-23  6:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  6:41 Cong Wang [this message]
2019-01-23 20:43 ` [Patch iproute2] tc: add performance counters for basic filter Stephen Hemminger
2019-01-24  1:14   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123064145.26169-1-xiyou.wangcong@gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox