From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
nhorman@tuxdriver.com
Subject: Re: [PATCH net] sctp: improve the events for sctp stream reset
Date: Thu, 24 Jan 2019 18:25:06 -0800 (PST) [thread overview]
Message-ID: <20190124.182506.271204705053172488.davem@davemloft.net> (raw)
In-Reply-To: <dc740e7814086bd4d759c39310c98b214a76ae21.1548095974.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Tue, 22 Jan 2019 02:39:34 +0800
> This patch is to improve sctp stream reset events in 4 places:
>
> 1. In sctp_process_strreset_outreq(), the flag should always be set with
> SCTP_STREAM_RESET_INCOMING_SSN instead of OUTGOING, as receiver's in
> stream is reset here.
> 2. In sctp_process_strreset_outreq(), move up SCTP_STRRESET_ERR_WRONG_SSN
> check, as the reset has to succeed after reconf_timer stops for the
> in stream reset request retransmission.
> 3. In sctp_process_strreset_inreq(), no event should be sent, as no in
> or out stream is reset here.
> 4. In sctp_process_strreset_resp(), SCTP_STREAM_RESET_INCOMING_SSN or
> OUTGOING event should always be sent for stream reset requests, no
> matter it fails or succeeds to process the request.
>
> Fixes: 810544764536 ("sctp: implement receiver-side procedures for the Outgoing SSN Reset Request Parameter")
> Fixes: 16e1a91965b0 ("sctp: implement receiver-side procedures for the Incoming SSN Reset Request Parameter")
> Fixes: 11ae76e67a17 ("sctp: implement receiver-side procedures for the Reconf Response Parameter")
> Reported-by: Ying Xu <yinxu@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2019-01-25 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 18:39 [PATCH net] sctp: improve the events for sctp stream reset Xin Long
2019-01-25 2:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124.182506.271204705053172488.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox