From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: daniel@iogearbox.net, oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier
Date: Sun, 27 Jan 2019 10:33:28 -0800 [thread overview]
Message-ID: <20190127103328.266e363e@cakuba.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20190126062120.pzb4jw2rzv6o5jp3@ast-mbp.dhcp.thefacebook.com>
On Fri, 25 Jan 2019 22:21:22 -0800, Alexei Starovoitov wrote:
> On Fri, Jan 25, 2019 at 10:17:28PM -0800, Jakub Kicinski wrote:
> > On Fri, 25 Jan 2019 21:55:30 -0800, Alexei Starovoitov wrote:
> > > On Fri, Jan 25, 2019 at 03:24:41PM -0800, Jakub Kicinski wrote:
> > > > Hi!
> > > >
> > > > The tools/testing/selftests/bpf/test_verifier.c file is
> > > > way too large, and since most people add their at the
> > > > end of the list it's very prone to conflicts.
> > > >
> > > > Break it up in the simplest possible way - slice the
> > > > array up into smaller C files and include them in the
> > > > right spot.
> > > >
> > > > Tested:
> > > > $ make -C tools/testing/selftests/bpf/
> > > > $ cd tools/testing/selftests/bpf/ ; make
> > > >
> > > > v2:
> > > >
> > > > The indentation is reduced further as discussed and lines folded.
> > > > The conversion was scripted, and double checked by hand.
> > >
> > > Looks great to me, but even first patch conflicts too much to apply.
> > > Please respin one more time.
> >
> > I could have sworn when I pulled bpf-next this morning Jiong's patches
> > were in it ;) I'll rebase/repost tomorrow morning.
>
> They were ;) until they were pulled off.
> Any order is fine.
Looks like v2 just applies cleanly again, should I repost?
next prev parent reply other threads:[~2019-01-27 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 23:24 [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier Jakub Kicinski
2019-01-25 23:24 ` [PATCH bpf-next v2 1/3] selftests: bpf: prepare for break up of verifier tests Jakub Kicinski
2019-01-25 23:24 ` [PATCH bpf-next v2 3/3] selftests: bpf: break up the rest of test_verifier Jakub Kicinski
2019-01-26 5:55 ` [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier Alexei Starovoitov
2019-01-26 6:17 ` Jakub Kicinski
2019-01-26 6:21 ` Alexei Starovoitov
2019-01-27 18:33 ` Jakub Kicinski [this message]
2019-01-27 20:56 ` Alexei Starovoitov
[not found] ` <20190127205413.231fcc05@cakuba.hsd1.ca.comcast.net>
2019-01-28 5:57 ` Alexei Starovoitov
2019-01-28 16:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127103328.266e363e@cakuba.hsd1.ca.comcast.net \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox