From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: dsahern@gmail.com, stephen@networkplumber.org,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH iproute2-next v2] devlink: add info subcommand
Date: Mon, 4 Feb 2019 08:10:59 +0100 [thread overview]
Message-ID: <20190204071059.GC2249@nanopsycho> (raw)
In-Reply-To: <20190204005456.22912-1-jakub.kicinski@netronome.com>
Mon, Feb 04, 2019 at 01:54:56AM CET, jakub.kicinski@netronome.com wrote:
>Add support for reading the device serial number, driver name
>and various versions. Example:
>
>$ devlink dev info pci/0000:05:00.0
>pci/0000:05:00.0:
> driver nfp
> serial_number 16240145
> versions:
> fixed:
> board.id AMDA0099-0001
> board.rev 07
> board.vendor SMA
> board.model carbon
> running:
> fw.mgmt: 010156.010156.010156
Sometimes you have "x: y" and sometimes you have "x y". Please be
consistent.
Please also include json output here.
Thanks!
> fw.cpld: 0x44
> fw.app: sriov-2.1.16
> stored:
> fw.mgmt: 010158.010158.010158
> fw.cpld: 0x44
> fw.app: sriov-2.1.20
>
>v2 (Jiri):
> - remove filtering;
> - add example in the commit message.
>RFCv2:
> - make info subcommand of dev.
>
[...]
prev parent reply other threads:[~2019-02-04 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 0:54 [PATCH iproute2-next v2] devlink: add info subcommand Jakub Kicinski
2019-02-04 7:10 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204071059.GC2249@nanopsycho \
--to=jiri@resnulli.us \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox