From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: Benedict Wong <benedictwong@google.com>,
Greg Kroah-Hartman <gregkh@google.com>,
Linux NetDev <netdev@vger.kernel.org>,
Nathan Harold <nharold@google.com>,
Lorenzo Colitti <lorenzo@google.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Eyal Birger <eyal.birger@gmail.com>,
tobias@strongswan.org
Subject: Re: [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility
Date: Wed, 6 Feb 2019 17:29:38 +0100 [thread overview]
Message-ID: <20190206162938.GB22989@kroah.com> (raw)
In-Reply-To: <CANP3RGcdptMfnJXQNjNdiD4kuoZxj4vETro_aWRQqzsxY=yAfQ@mail.gmail.com>
On Tue, Feb 05, 2019 at 02:54:29PM -0800, Maciej Żenczykowski wrote:
> > I propose backporting commit e2612cd496e7 ("xfrm: Make set-mark default
> > behavior backward compatible") to 4.19 and 4.20 kernels to fix a backwards
> > compatibility bug introduced in 9b42c1f179a6 (“xfrm: Extend the
> > output_mark to support input direction and masking”).
> >
> > The fix is small, relatively simple, and has unit tests. :)
> >
> > Without this change, systems using mark-based routing on 4.19 or 4.20
> > kernels will by fail to route IPsec tunnel mode packets correctly in the
> > default case. This specifically affects Android devices.
>
> Looks like it already includes a 'fixes: sha1' tag.
> I'm not sure what causes these patches to get picked up for stable...
> I'm guessing it's some sort of Greg-fu-style-magic...?
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Hint, putting a fixes tag there does NOT trigger my scripts...
prev parent reply other threads:[~2019-02-06 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 21:59 [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility Benedict Wong
2019-02-05 22:54 ` Maciej Żenczykowski
2019-02-06 16:29 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206162938.GB22989@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benedictwong@google.com \
--cc=eyal.birger@gmail.com \
--cc=gregkh@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=nharold@google.com \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox