* [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility
@ 2019-02-05 21:59 Benedict Wong
2019-02-05 22:54 ` Maciej Żenczykowski
0 siblings, 1 reply; 3+ messages in thread
From: Benedict Wong @ 2019-02-05 21:59 UTC (permalink / raw)
To: netdev
Cc: Nathan Harold, Lorenzo Colitti, Steffen Klassert,
Maciej Żenczykowski, Eyal Birger, tobias
I propose backporting commit e2612cd496e7 ("xfrm: Make set-mark default
behavior backward compatible") to 4.19 and 4.20 kernels to fix a backwards
compatibility bug introduced in 9b42c1f179a6 (“xfrm: Extend the
output_mark to support input direction and masking”).
The fix is small, relatively simple, and has unit tests. :)
Without this change, systems using mark-based routing on 4.19 or 4.20
kernels will by fail to route IPsec tunnel mode packets correctly in the
default case. This specifically affects Android devices.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility
2019-02-05 21:59 [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility Benedict Wong
@ 2019-02-05 22:54 ` Maciej Żenczykowski
2019-02-06 16:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Maciej Żenczykowski @ 2019-02-05 22:54 UTC (permalink / raw)
To: Benedict Wong, Greg Kroah-Hartman, Greg Kroah-Hartman
Cc: Linux NetDev, Nathan Harold, Lorenzo Colitti, Steffen Klassert,
Eyal Birger, tobias
> I propose backporting commit e2612cd496e7 ("xfrm: Make set-mark default
> behavior backward compatible") to 4.19 and 4.20 kernels to fix a backwards
> compatibility bug introduced in 9b42c1f179a6 (“xfrm: Extend the
> output_mark to support input direction and masking”).
>
> The fix is small, relatively simple, and has unit tests. :)
>
> Without this change, systems using mark-based routing on 4.19 or 4.20
> kernels will by fail to route IPsec tunnel mode packets correctly in the
> default case. This specifically affects Android devices.
Looks like it already includes a 'fixes: sha1' tag.
I'm not sure what causes these patches to get picked up for stable...
I'm guessing it's some sort of Greg-fu-style-magic...?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility
2019-02-05 22:54 ` Maciej Żenczykowski
@ 2019-02-06 16:29 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-02-06 16:29 UTC (permalink / raw)
To: Maciej Żenczykowski
Cc: Benedict Wong, Greg Kroah-Hartman, Linux NetDev, Nathan Harold,
Lorenzo Colitti, Steffen Klassert, Eyal Birger, tobias
On Tue, Feb 05, 2019 at 02:54:29PM -0800, Maciej Żenczykowski wrote:
> > I propose backporting commit e2612cd496e7 ("xfrm: Make set-mark default
> > behavior backward compatible") to 4.19 and 4.20 kernels to fix a backwards
> > compatibility bug introduced in 9b42c1f179a6 (“xfrm: Extend the
> > output_mark to support input direction and masking”).
> >
> > The fix is small, relatively simple, and has unit tests. :)
> >
> > Without this change, systems using mark-based routing on 4.19 or 4.20
> > kernels will by fail to route IPsec tunnel mode packets correctly in the
> > default case. This specifically affects Android devices.
>
> Looks like it already includes a 'fixes: sha1' tag.
> I'm not sure what causes these patches to get picked up for stable...
> I'm guessing it's some sort of Greg-fu-style-magic...?
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Hint, putting a fixes tag there does NOT trigger my scripts...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-06 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-05 21:59 [xfrm, backport request] Request backport of e2612cd496e7 - set-mark backwards compatibility Benedict Wong
2019-02-05 22:54 ` Maciej Żenczykowski
2019-02-06 16:29 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox