From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Haller <thaller@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2, v2] ip-rule: fix json key "to_tbl" for unspecific rule action
Date: Tue, 19 Feb 2019 15:22:06 -0800 [thread overview]
Message-ID: <20190219152206.7d79da00@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190219205019.30757-1-thaller@redhat.com>
On Tue, 19 Feb 2019 21:50:19 +0100
Thomas Haller <thaller@redhat.com> wrote:
> The key should not be called "to_tbl" because it is exactly
> not a FR_ACT_TO_TBL action. Change it to "action".
>
> # ip rule add blackhole
> # ip -j rule | python -m json.tool
> ...
> {
> "priority": 0,
> "src": "all",
> "to_tbl": "blackhole"
> },
>
> This is an API break of JSON output as it was added in v4.17.0.
> Still change it as the API is relatively new and unstable.
>
> Fixes: 0dd4ccc56c0e ("iprule: add json support")
>
> Signed-off-by: Thomas Haller <thaller@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2019-02-19 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 14:03 [PATCH iproute2] ip-rule/trivial: add comment about json key "to_tbl" for unspecific rule action Thomas Haller
2019-02-19 18:19 ` Stephen Hemminger
2019-02-19 20:50 ` [PATCH iproute2, v2] ip-rule: fix " Thomas Haller
2019-02-19 23:22 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219152206.7d79da00@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox