From: Jiri Pirko <jiri@resnulli.us>
To: Aya Levin <ayal@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>
Subject: Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately
Date: Thu, 21 Feb 2019 15:08:37 +0100 [thread overview]
Message-ID: <20190221140837.GO2312@nanopsycho> (raw)
In-Reply-To: <1550756567-18227-5-git-send-email-ayal@mellanox.com>
Thu, Feb 21, 2019 at 02:42:40PM CET, ayal@mellanox.com wrote:
>Add a new helper functions which outputs only values (without name
>label) for different types: boolean, uint, uint64, string and binary.
>In addition add a helper function which prints only the name label.
>
>Signed-off-by: Aya Levin <ayal@mellanox.com>
>Reviewed-by: Moshe Shemesh <moshe@mellanox.com>
>---
> devlink/devlink.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 65 insertions(+), 1 deletion(-)
>
>diff --git a/devlink/devlink.c b/devlink/devlink.c
>index b073ae020d52..5d69c4f24f29 100644
>--- a/devlink/devlink.c
>+++ b/devlink/devlink.c
>@@ -1588,7 +1588,6 @@ static void pr_out_port_handle_end(struct dl *dl)
> pr_out("\n");
> }
>
>-
Please avoid changes like this.
[...]
next prev parent reply other threads:[~2019-02-21 14:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 13:42 [PATCH v2 iproute2-next 00/11] Add support for devlink health Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 01/11] devlink: Refactor validation of finding required arguments Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 02/11] devlink: Fix print of uint64_t Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 03/11] devlink: Fix boolean JSON print Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately Aya Levin
2019-02-21 14:08 ` Jiri Pirko [this message]
2019-02-24 8:07 ` Aya Levin
2019-02-21 18:02 ` Stephen Hemminger
2019-02-22 8:58 ` Jiri Pirko
2019-02-22 18:01 ` Stephen Hemminger
2019-02-22 17:59 ` Jiri Pirko
2019-02-21 13:42 ` [PATCH v2 iproute2-next 05/11] devlink: Add devlink health show command Aya Levin
2019-02-21 14:25 ` Jiri Pirko
2019-02-21 13:42 ` [PATCH v2 iproute2-next 06/11] devlink: Add devlink health recover command Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 07/11] devlink: Add devlink health diagnose command Aya Levin
2019-02-21 14:28 ` Jiri Pirko
2019-02-21 13:42 ` [PATCH v2 iproute2-next 08/11] devlink: Add devlink health dump show command Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 09/11] devlink: Add devlink health dump clear command Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 10/11] devlink: Add devlink health set command Aya Levin
2019-02-21 13:42 ` [PATCH v2 iproute2-next 11/11] devlink: Add devlink-health man page Aya Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221140837.GO2312@nanopsycho \
--to=jiri@resnulli.us \
--cc=ayal@mellanox.com \
--cc=dsahern@gmail.com \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox