From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: check PMAPMD link status only in genphy_c45_read_link
Date: Sun, 24 Feb 2019 17:43:37 -0800 (PST) [thread overview]
Message-ID: <20190224.174337.1452333811738028062.davem@davemloft.net> (raw)
In-Reply-To: <9c7b68ea-ac30-a7ec-1c88-ae819dbbb7b4@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 22 Feb 2019 22:59:38 +0100
> The current code reports a link as up if all devices (except a few
> blacklisted ones) report the link as up. This breaks Aquantia AQCS109
> for lower speeds because on this PHY the PCS link status reflects a
> 10G link only. For Marvell there's a similar issue, therefore PHYXS
> device isn't checked.
>
> There may be more PHYs where depending on the mode the link status
> of only selected devices is relevant.
>
> For now it seems to be sufficient to check the link status of the
> PMAPMD device only. Leave the loop in the code to be prepared in
> case we have to add functionality to check more than one device,
> depending on the mode.
>
> Successfully tested on a board with an AQCS109.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
prev parent reply other threads:[~2019-02-25 1:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 21:59 [PATCH net-next] net: phy: check PMAPMD link status only in genphy_c45_read_link Heiner Kallweit
2019-02-25 1:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190224.174337.1452333811738028062.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox