From: Sabrina Dubroca <sd@queasysnail.net>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>,
Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH net v2 2/2] selftests: pmtu: add explicit tests for PMTU exceptions cleanup
Date: Mon, 25 Feb 2019 13:33:30 +0100 [thread overview]
Message-ID: <20190225123330.GA10994@bistromath.localdomain> (raw)
In-Reply-To: <6d6f6a2512743d6e1968dbfe765eb85b478bd033.1551093086.git.pabeni@redhat.com>
2019-02-25, 12:13:46 +0100, Paolo Abeni wrote:
> + if ! timeout 1 ${ns_a} ip link del dev veth_A-R1; then
That doesn't work. "ip link del" is stuck in a way that timeout can't
terminate it, so this is still going to hang. Did you actually test
this? :/
> + err " can't delete veth device in a timely manner, PMTU dst likely leaked"
> + return 1
> + fi
> + return 0
> +}
--
Sabrina
next prev parent reply other threads:[~2019-02-25 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 11:13 [PATCH net v2 0/2] selftests: pmtu: fix and increase coverage Paolo Abeni
2019-02-25 11:13 ` [PATCH net v2 1/2] selftests: pmtu: disable DAD in all namespaces Paolo Abeni
2019-02-25 11:13 ` [PATCH net v2 2/2] selftests: pmtu: add explicit tests for PMTU exceptions cleanup Paolo Abeni
2019-02-25 11:35 ` Stefano Brivio
2019-02-25 12:33 ` Sabrina Dubroca [this message]
2019-02-25 12:56 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225123330.GA10994@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox