From: Jiri Pirko <jiri@resnulli.us>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
idosch@mellanox.com, jakub.kicinski@netronome.com,
dirk.vandermerwe@netronome.com, f.fainelli@gmail.com,
andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [patch net-next 1/5] net: replace ndo_get_devlink for ndo_get_devlink_port
Date: Fri, 1 Mar 2019 14:42:43 +0100 [thread overview]
Message-ID: <20190301134243.GI2314@nanopsycho> (raw)
In-Reply-To: <20190301124526.GF29992@unicorn.suse.cz>
Fri, Mar 01, 2019 at 01:45:26PM CET, mkubecek@suse.cz wrote:
>On Fri, Mar 01, 2019 at 09:13:58AM +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Follow-up patch is going to need a devlink port instance according to
>> a netdev. Devlink port instance should be always available when devlink
>> is used.
>
>I noticed netdevsim has devlink interface but it does not register
>devlink ports for its network devices. But that seems to be rather an
>omission in netdevsim, right?
Yep.
>
>> So change the recently introduced ndo_get_devlink to
>> ndo_get_devlink_port. With that, adjust the wrapper for the only
>> user to get devlink pointer.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
>Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Thanks.
next prev parent reply other threads:[~2019-03-01 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 8:13 [patch net-next 0/5] net: call for phys_port_name into devlink directly is possible Jiri Pirko
2019-03-01 8:13 ` [patch net-next 1/5] net: replace ndo_get_devlink for ndo_get_devlink_port Jiri Pirko
2019-03-01 12:45 ` Michal Kubecek
2019-03-01 13:42 ` Jiri Pirko [this message]
2019-03-02 2:20 ` Florian Fainelli
2019-03-01 8:13 ` [patch net-next 2/5] net: devlink: introduce devlink_compat_phys_port_name_get() Jiri Pirko
2019-03-01 16:14 ` Jakub Kicinski
2019-03-01 16:21 ` Jiri Pirko
2019-03-01 8:14 ` [patch net-next 3/5] mlxsw: spectrum: Implement ndo_get_devlink_port Jiri Pirko
2019-03-01 8:14 ` [patch net-next 4/5] mlxsw: Remove ndo_get_phys_port_name implementation Jiri Pirko
2019-03-01 8:14 ` [patch net-next 5/5] net: devlink: remove unused devlink_port_get_phys_port_name() function Jiri Pirko
2019-03-01 16:25 ` Jakub Kicinski
2019-03-01 16:27 ` Jiri Pirko
2019-03-01 16:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301134243.GI2314@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox