From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Miller <davem@davemloft.net>
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 0/2] nfp: fix retcode and disable netpoll on representors
Date: Thu, 28 Mar 2019 17:27:50 -0700 [thread overview]
Message-ID: <20190328172750.05e30c6c@cakuba.netronome.com> (raw)
In-Reply-To: <20190328.170453.1247086248564076817.davem@davemloft.net>
On Thu, 28 Mar 2019 17:04:53 -0700 (PDT), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Wed, 27 Mar 2019 11:38:37 -0700
>
> > This series avoids a potential crash on nfp representor devices
> > when netpoll is in use. If transmitting the frame through underlying
> > vNIC fails we'd return an error code (by passing on error code from
> > __dev_queue_xmit()) and cause double free in netpoll code.
> >
> > Fix the error code and disable netpoll on reprs altogether.
> > IRQ-safety of locking the queues and calling __dev_queue_xmit()
> > is questionable.
> >
> > Big thanks to John Hurley for debugging and narrowing down
> > the trace log after I gave up! :)
>
> Series applied, thanks Jakub.
>
> Want me to queue these up for -stable?
Mm.. yes, I think so, patch 1 can lead to a hard to catch double free.
Thanks!
next prev parent reply other threads:[~2019-03-29 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 18:38 [PATCH net 0/2] nfp: fix retcode and disable netpoll on representors Jakub Kicinski
2019-03-27 18:38 ` [PATCH net 1/2] nfp: validate the return code from dev_queue_xmit() Jakub Kicinski
2019-03-27 18:38 ` [PATCH net 2/2] nfp: disable netpoll on representors Jakub Kicinski
2019-03-29 0:04 ` [PATCH net 0/2] nfp: fix retcode and " David Miller
2019-03-29 0:27 ` Jakub Kicinski [this message]
2019-03-29 0:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328172750.05e30c6c@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox