From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
hkallweit1@gmail.com, nic_swsd@realtek.com,
netdev@vger.kernel.org, ecree@solarflare.com, brouer@redhat.com
Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching
Date: Mon, 1 Apr 2019 14:53:26 +0200 [thread overview]
Message-ID: <20190401145326.0196c746@carbon> (raw)
In-Reply-To: <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com>
On Mon, 1 Apr 2019 02:17:12 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On 03/31/2019 11:11 AM, David Miller wrote:
> > From: Heiner Kallweit <hkallweit1@gmail.com>
> > Date: Sun, 31 Mar 2019 15:18:48 +0200
> >
> >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit
> >> from batched skb processing.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > Applied.
> >
>
> This means no GRO at all, and reduced performance in many useful
> cases.
As Eric says, this in-effect disables GRO for this driver. This will
very likely give a slowdown for local TCP delivery (while it might
helps for UDP and forwarding).
That is why I was saying we need a GRO version of this...
(which need to be combined with bulk SKB alloc, to compete with GRO
fast-recycle of same SKB).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-04-01 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 13:18 [PATCH net-next] r8169: use netif_receive_skb_list batching Heiner Kallweit
2019-03-31 18:11 ` David Miller
2019-04-01 9:17 ` Eric Dumazet
2019-04-01 12:53 ` Jesper Dangaard Brouer [this message]
2019-04-01 17:41 ` David Miller
2019-04-01 21:33 ` Eric Dumazet
2019-04-01 17:14 ` David Miller
2019-04-01 17:31 ` Edward Cree
2019-04-01 17:39 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401145326.0196c746@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox