public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Captain Wiggum <captwiggum@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Westphal <fw@strlen.de>,
	Eric Dumazet <edumazet@google.com>,
	Peter Oskolkov <posk@google.com>,
	netdev@vger.kernel.org
Subject: Re: Please merge IPv6 fix for drop fragment smaller than MTU
Date: Mon, 1 Apr 2019 23:48:47 +0200	[thread overview]
Message-ID: <20190401214847.7aa5l4wpiyita75x@breakpoint.cc> (raw)
In-Reply-To: <CAB=W+ok36bXgj7Dmkid1bM8h_Hq-D=4mnfFrreQBxGy=2_k1Rw@mail.gmail.com>

Captain Wiggum <captwiggum@gmail.com> wrote:
> An error was introduced in 4.9.134 (and the other LTS branches also).
> This causes 18 test cases from the TAHI IPv6 test suite to fail.
> I added you to the mail thread about this subject a month back.
> It has been fixed in upstream for some time now, but not in the LTS branches.
> Please merge this undo-patch into the LTS branches.

This is only safe after backporting Peters work to convert
IPv6 to use RB Trees for the reassembly queues,
otherwise a revert adds back the DoS vector.

commit d4289fcc9b16b89619ee1c54f829e05e56de8b9a
net: IP6 defrag: use rbtrees for IPv6 defrag

commit 997dd96471641e147cb2c33ad54284000d0f5e35
net: IP6 defrag: use rbtrees in nf_conntrack_reasm.c


  reply	other threads:[~2019-04-01 21:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 21:34 Please merge IPv6 fix for drop fragment smaller than MTU Captain Wiggum
2019-04-01 21:48 ` Florian Westphal [this message]
2019-04-01 21:53   ` Captain Wiggum
2019-04-02  6:38 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401214847.7aa5l4wpiyita75x@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=captwiggum@gmail.com \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=posk@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox