From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration
Date: Wed, 17 Apr 2019 00:25:53 +0200 [thread overview]
Message-ID: <20190416222553.GA25164@lunn.ch> (raw)
In-Reply-To: <09a26e61-aa21-8be7-0f51-38897abb2f7b@gmail.com>
> @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = {
> .phy_id = PHY_ID_BCM8706,
> .phy_id_mask = 0xffffffff,
> .name = "Broadcom BCM8706",
> - .features = PHY_10GBIT_FEC_FEATURES,
> + .get_features = bcm87xx_get_features,
> .config_init = bcm87xx_config_init,
> .config_aneg = bcm87xx_config_aneg,
> .read_status = bcm87xx_read_status,
> @@ -206,7 +203,7 @@ static struct phy_driver bcm87xx_driver[] = {
> .phy_id = PHY_ID_BCM8727,
> .phy_id_mask = 0xffffffff,
> .name = "Broadcom BCM8727",
> - .features = PHY_10GBIT_FEC_FEATURES,
> + .get_features = bcm87xx_get_features,
> .config_init = bcm87xx_config_init,
> .config_aneg = bcm87xx_config_aneg,
> .read_status = bcm87xx_read_status,
Hi Heiner
The product briefs for these two devices say:
MDIO interface compliant to IEEE802.3ae Clause 45 with
extended indirect address register access
It might be possible to just detect most of this?
Florian: Do you have access to any boards using these devices?
Andrew
next prev parent reply other threads:[~2019-04-16 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 22:06 [PATCH net-next] net: phy: bcm87xx: improve feature configuration Heiner Kallweit
2019-04-16 22:25 ` Andrew Lunn [this message]
2019-04-16 22:34 ` Heiner Kallweit
2019-04-16 23:47 ` Florian Fainelli
2019-04-18 23:30 ` David Miller
2019-04-25 17:32 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416222553.GA25164@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox