From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
dsahern@gmail.com
Subject: Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items
Date: Fri, 19 Apr 2019 07:27:45 +0200 [thread overview]
Message-ID: <20190419052745.GB2247@nanopsycho> (raw)
In-Reply-To: <20190418101722.19af3467@cakuba.netronome.com>
Thu, Apr 18, 2019 at 07:17:22PM CEST, jakub.kicinski@netronome.com wrote:
>On Thu, 18 Apr 2019 16:06:02 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> The existing devlink.c code is going to be extended to represent asic
>> device on a bus. As this is about more than just devlink,
>> rename the file. Do appropriate prefix renaming alongside with that.
>
>Again, devlink != bus device. I don't like this change at all.
>
>Keep them separate, please, unless you _need_ such a change for testing.
I have them separate. There is just 1:1 mapping between bus_device
(dev.c) file, and devlink instance. There is nothing preventing to have
the mapping in a different way. This is basically just a file name
change to better fit what is done in the file.
next prev parent reply other threads:[~2019-04-19 21:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 14:05 [patch net-next 00/15] netdevsim: impement proper device model Jiri Pirko
2019-04-18 14:06 ` [patch net-next 01/15] netdevsim: move device registration on bus to be done earlier in init Jiri Pirko
2019-04-18 17:11 ` Jakub Kicinski
2019-04-18 14:06 ` [patch net-next 02/15] netdevsim: create devlink instance per netdevsim instance Jiri Pirko
2019-04-18 14:06 ` [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items Jiri Pirko
2019-04-18 17:17 ` Jakub Kicinski
2019-04-19 5:27 ` Jiri Pirko [this message]
2019-04-18 14:06 ` [patch net-next 04/15] netdevsim: put netdevsim bus code into separate file Jiri Pirko
2019-04-18 14:06 ` [patch net-next 05/15] netdevsim: move device registration and related code to bus.c Jiri Pirko
2019-04-18 14:06 ` [patch net-next 06/15] netdevsim: add stub netdevsim driver implementation Jiri Pirko
2019-04-18 14:06 ` [patch net-next 07/15] netdevsim: use ida for bus device ids Jiri Pirko
2019-04-18 14:06 ` [patch net-next 08/15] netdevsim: add bus attributes to add new and delete devices Jiri Pirko
2019-04-18 14:06 ` [patch net-next 09/15] netdevsim: rename dev_init/exit() functions and make them independent on ns Jiri Pirko
2019-04-18 14:06 ` [patch net-next 10/15] netdevsim: merge sdev into dev Jiri Pirko
2019-04-18 14:06 ` [patch net-next 11/15] netdevsim: generate random switch id instead of using dev id Jiri Pirko
2019-04-18 14:06 ` [patch net-next 12/15] netdevsim: change debugfs tree topology Jiri Pirko
2019-04-18 14:06 ` [patch net-next 13/15] netdevsim: implement dev probe/remove skeleton with port initialization Jiri Pirko
2019-04-18 14:06 ` [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe Jiri Pirko
2019-04-18 17:25 ` Jakub Kicinski
2019-04-19 5:28 ` Jiri Pirko
2019-04-19 21:11 ` Jakub Kicinski
2019-04-18 14:06 ` [patch net-next 15/15] netdevsim: implement ndo_get_devlink_port Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419052745.GB2247@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox