From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: jiri@resnulli.us, netdev@vger.kernel.org, mlxsw@mellanox.com,
dsahern@gmail.com
Subject: Re: [patch net-next v4 00/16] netdevsim: implement proper device model
Date: Fri, 26 Apr 2019 01:52:20 -0400 (EDT) [thread overview]
Message-ID: <20190426.015220.2082398991607902079.davem@davemloft.net> (raw)
In-Reply-To: <20190425151117.5082bc01@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 25 Apr 2019 15:11:17 -0700
> On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Currently the model of netdevsim is a bit odd in multiple ways.
>> 1) devlink instance is not in any way related with actual netdevsim
>> netdevices. Instead, it is created per-namespace.
>> 2) multi-port netdevsim device is done using "link" attribute.
>> 3) netdevsim bus is there only to have something to bind the netdev to,
>> it really does not act as a bus.
>> 4) netdevsim instances are created by "ip link add" which is great for
>> soft devices with no hw backend. The rtnl core allocates netdev and
>> calls into driver holding rtnl mutex. For hw-backed devices, this
>> flow is wrong as it breaks order in which things are done.
>>
>> This patchset adjust netdevsim to fix all above.
>
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Series applied, thanks everyone.
prev parent reply other threads:[~2019-04-26 5:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 13:59 [patch net-next v4 00/16] netdevsim: implement proper device model Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 01/16] netdevsim: move device registration on bus to be done earlier in init Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 02/16] netdevsim: create devlink instance per netdevsim instance Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 03/16] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 04/16] netdevsim: put netdevsim bus code into separate file Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 05/16] netdevsim: move device registration and related code to bus.c Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 06/16] netdevsim: add stub netdevsim driver implementation Jiri Pirko
2019-04-25 15:38 ` Sergei Shtylyov
2019-04-25 13:59 ` [patch net-next v4 07/16] netdevsim: use ida for bus device ids Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 08/16] netdevsim: add bus attributes to add new and delete devices Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 09/16] netdevsim: rename dev_init/exit() functions and make them independent on ns Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 10/16] netdevsim: merge sdev into dev Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 11/16] netdevsim: generate random switch id instead of using dev id Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 12/16] netdevsim: change debugfs tree topology Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 13/16] netdevsim: implement dev probe/remove skeleton with port initialization Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 14/16] netdevsim: extend device attrs to support port addition and deletion Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 15/16] netdevsim: move netdev creation/destruction to dev probe Jiri Pirko
2019-04-25 13:59 ` [patch net-next v4 16/16] netdevsim: implement ndo_get_devlink_port Jiri Pirko
2019-04-25 14:02 ` [patch net-next v4 00/16] netdevsim: implement proper device model Jiri Pirko
2019-04-25 22:11 ` Jakub Kicinski
2019-04-26 5:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426.015220.2082398991607902079.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox