From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Kristian Evensen <kristian.evensen@gmail.com>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression
Date: Mon, 6 May 2019 15:16:05 +0200 [thread overview]
Message-ID: <20190506131605.kapyns6gkyphbea2@salvia> (raw)
In-Reply-To: <4ecbebbb-0a7f-6d45-c2c0-00dee746e573@6wind.com>
On Mon, May 06, 2019 at 10:49:52AM +0200, Nicolas Dichtel wrote:
> Le 06/05/2019 à 00:32, Pablo Neira Ayuso a écrit :
> > On Fri, May 03, 2019 at 05:40:07PM +0200, Kristian Evensen wrote:
> >> Commit 59c08c69c278 ("netfilter: ctnetlink: Support L3 protocol-filter
> >> on flush") introduced a user-space regression when flushing connection
> >> track entries. Before this commit, the nfgen_family field was not used
> >> by the kernel and all entries were removed. Since this commit,
> >> nfgen_family is used to filter out entries that should not be removed.
> >> One example a broken tool is conntrack. conntrack always sets
> >> nfgen_family to AF_INET, so after 59c08c69c278 only IPv4 entries were
> >> removed with the -F parameter.
> >>
> >> Pablo Neira Ayuso suggested using nfgenmsg->version to resolve the
> >> regression, and this commit implements his suggestion. nfgenmsg->version
> >> is so far set to zero, so it is well-suited to be used as a flag for
> >> selecting old or new flush behavior. If version is 0, nfgen_family is
> >> ignored and all entries are used. If user-space sets the version to one
> >> (or any other value than 0), then the new behavior is used. As version
> >> only can have two valid values, I chose not to add a new
> >> NFNETLINK_VERSION-constant.
> >
> > Applied, thanks.
> >
> Thank you.
> Is it possible to queue this for stable?
Sure, as soon as this hits Linus' tree.
next prev parent reply other threads:[~2019-05-06 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 15:40 [PATCH] netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression Kristian Evensen
2019-05-03 17:02 ` Nicolas Dichtel
2019-05-03 17:05 ` Pablo Neira Ayuso
2019-05-04 10:57 ` Kristian Evensen
2019-05-05 22:32 ` Pablo Neira Ayuso
2019-05-06 8:49 ` Nicolas Dichtel
2019-05-06 13:16 ` Pablo Neira Ayuso [this message]
2019-05-20 8:35 ` Nicolas Dichtel
2019-05-24 9:22 ` Pablo Neira Ayuso
2019-05-28 13:57 ` Nicolas Dichtel
2019-05-28 22:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506131605.kapyns6gkyphbea2@salvia \
--to=pablo@netfilter.org \
--cc=kristian.evensen@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox