* [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static
@ 2019-06-03 8:04 Rasmus Villemoes
2019-06-03 14:06 ` Vivien Didelot
2019-06-03 17:09 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rasmus Villemoes @ 2019-06-03 8:04 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller
Cc: Rasmus Villemoes, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
mv88e6xxx_g1_stats_wait has no users outside global1.c, so make it
static.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
drivers/net/dsa/mv88e6xxx/global1.c | 2 +-
drivers/net/dsa/mv88e6xxx/global1.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/global1.c b/drivers/net/dsa/mv88e6xxx/global1.c
index b5ceff2946fe..770c03406033 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.c
+++ b/drivers/net/dsa/mv88e6xxx/global1.c
@@ -465,7 +465,7 @@ int mv88e6xxx_g1_set_device_number(struct mv88e6xxx_chip *chip, int index)
/* Offset 0x1d: Statistics Operation 2 */
-int mv88e6xxx_g1_stats_wait(struct mv88e6xxx_chip *chip)
+static int mv88e6xxx_g1_stats_wait(struct mv88e6xxx_chip *chip)
{
return mv88e6xxx_g1_wait(chip, MV88E6XXX_G1_STATS_OP,
MV88E6XXX_G1_STATS_OP_BUSY);
diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h
index 2f195a0bd891..bb92a130cbef 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.h
+++ b/drivers/net/dsa/mv88e6xxx/global1.h
@@ -263,7 +263,6 @@ int mv88e6352_g1_reset(struct mv88e6xxx_chip *chip);
int mv88e6185_g1_ppu_enable(struct mv88e6xxx_chip *chip);
int mv88e6185_g1_ppu_disable(struct mv88e6xxx_chip *chip);
-int mv88e6xxx_g1_stats_wait(struct mv88e6xxx_chip *chip);
int mv88e6xxx_g1_stats_snapshot(struct mv88e6xxx_chip *chip, int port);
int mv88e6320_g1_stats_snapshot(struct mv88e6xxx_chip *chip, int port);
int mv88e6390_g1_stats_snapshot(struct mv88e6xxx_chip *chip, int port);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static
2019-06-03 8:04 [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static Rasmus Villemoes
@ 2019-06-03 14:06 ` Vivien Didelot
2019-06-03 17:09 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2019-06-03 14:06 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Andrew Lunn, Florian Fainelli, David S. Miller, Rasmus Villemoes,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Mon, 3 Jun 2019 08:04:09 +0000, Rasmus Villemoes <rasmus.villemoes@prevas.dk> wrote:
> mv88e6xxx_g1_stats_wait has no users outside global1.c, so make it
> static.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static
2019-06-03 8:04 [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static Rasmus Villemoes
2019-06-03 14:06 ` Vivien Didelot
@ 2019-06-03 17:09 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-03 17:09 UTC (permalink / raw)
To: rasmus.villemoes
Cc: andrew, vivien.didelot, f.fainelli, Rasmus.Villemoes, netdev,
linux-kernel
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Date: Mon, 3 Jun 2019 08:04:09 +0000
> mv88e6xxx_g1_stats_wait has no users outside global1.c, so make it
> static.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-03 8:04 [PATCH] net: dsa: mv88e6xxx: make mv88e6xxx_g1_stats_wait static Rasmus Villemoes
2019-06-03 14:06 ` Vivien Didelot
2019-06-03 17:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox