* [PATCH] ipsec: select CRYPTO_HASH for xfrm_algo
@ 2019-06-18 7:14 Arnd Bergmann
2019-06-18 8:00 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-06-18 7:14 UTC (permalink / raw)
To: Steffen Klassert, Herbert Xu, David S. Miller
Cc: Arnd Bergmann, Florian Westphal, netdev, linux-kernel
kernelci.org reports failed builds on arc because of what looks
like an old missed 'select' statement:
net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs':
xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash'
I don't see this in randconfig builds on other architectures, but
it's fairly clear we want to select the hash code for it, like we
do for all its other users.
Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/xfrm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index c967fc3c38c8..a5c967efe5f4 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -15,6 +15,7 @@ config XFRM_ALGO
tristate
select XFRM
select CRYPTO
+ select CRYPTO_HASH
if INET
config XFRM_USER
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ipsec: select CRYPTO_HASH for xfrm_algo
2019-06-18 7:14 [PATCH] ipsec: select CRYPTO_HASH for xfrm_algo Arnd Bergmann
@ 2019-06-18 8:00 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-06-18 8:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Steffen Klassert, David S. Miller, Florian Westphal, netdev,
linux-kernel
On Tue, Jun 18, 2019 at 09:14:51AM +0200, Arnd Bergmann wrote:
> kernelci.org reports failed builds on arc because of what looks
> like an old missed 'select' statement:
>
> net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs':
> xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash'
>
> I don't see this in randconfig builds on other architectures, but
> it's fairly clear we want to select the hash code for it, like we
> do for all its other users.
>
> Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> net/xfrm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
> index c967fc3c38c8..a5c967efe5f4 100644
> --- a/net/xfrm/Kconfig
> +++ b/net/xfrm/Kconfig
> @@ -15,6 +15,7 @@ config XFRM_ALGO
> tristate
> select XFRM
> select CRYPTO
> + select CRYPTO_HASH
You should also select CRYPTO_BLKCIPHER.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-18 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-18 7:14 [PATCH] ipsec: select CRYPTO_HASH for xfrm_algo Arnd Bergmann
2019-06-18 8:00 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox