From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, cpaasch@apple.com
Subject: Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()
Date: Fri, 21 Jun 2019 21:00:13 -0400 (EDT) [thread overview]
Message-ID: <20190621.210013.2186064936627293600.davem@davemloft.net> (raw)
In-Reply-To: <20190621130955.147974-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 21 Jun 2019 06:09:55 -0700
> tcp_fragment() might be called for skbs in the write queue.
>
> Memory limits might have been exceeded because tcp_sendmsg() only
> checks limits at full skb (64KB) boundaries.
>
> Therefore, we need to make sure tcp_fragment() wont punish applications
> that might have setup very low SO_SNDBUF values.
>
> Fixes: f070ef2ac667 ("tcp: tcp_fragment() should apply sane memory limits")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Christoph Paasch <cpaasch@apple.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2019-06-22 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 13:09 [PATCH net] tcp: refine memory limit test in tcp_fragment() Eric Dumazet
2019-06-21 14:50 ` Christoph Paasch
2019-06-22 1:00 ` David Miller [this message]
2019-07-03 3:27 ` Tony Lu
2019-07-03 9:19 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621.210013.2186064936627293600.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cpaasch@apple.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox