From: David Miller <davem@davemloft.net>
To: huangfq.daxian@gmail.com
Cc: jcliburn@gmail.com, chris.snook@gmail.com,
michael.chan@broadcom.com, vishal@chelsio.com,
fugang.duan@nxp.com, cooldavid@cooldavid.org,
mlindner@marvell.com, stephen@networkplumber.org,
tariqt@mellanox.com, saeedm@mellanox.com, leon@kernel.org,
jiri@mellanox.com, idosch@mellanox.com, jdmason@kudzu.us,
manishc@marvell.com, rahulv@marvell.com,
GR-Linux-NIC-Dev@marvell.com, chessman@tux.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v3 17/24] ethernet: remove redundant memset
Date: Mon, 15 Jul 2019 11:06:46 -0700 (PDT) [thread overview]
Message-ID: <20190715.110646.1964036532467569670.davem@davemloft.net> (raw)
In-Reply-To: <20190715031911.6982-1-huangfq.daxian@gmail.com>
From: Fuqian Huang <huangfq.daxian@gmail.com>
Date: Mon, 15 Jul 2019 11:19:11 +0800
> kvzalloc already zeroes the memory during the allocation.
> pci_alloc_consistent calls dma_alloc_coherent directly.
> In commit 518a2f1925c3
> ("dma-mapping: zero memory returned from dma_alloc_*"),
> dma_alloc_coherent has already zeroed the memory.
> So the memset after these function is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Applied.
prev parent reply other threads:[~2019-07-15 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 3:19 [PATCH v3 17/24] ethernet: remove redundant memset Fuqian Huang
2019-07-15 18:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715.110646.1964036532467569670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=chessman@tux.org \
--cc=chris.snook@gmail.com \
--cc=cooldavid@cooldavid.org \
--cc=fugang.duan@nxp.com \
--cc=huangfq.daxian@gmail.com \
--cc=idosch@mellanox.com \
--cc=jcliburn@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jiri@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rahulv@marvell.com \
--cc=saeedm@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=tariqt@mellanox.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox